New issue
Advanced search Search tips

Issue 761999 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:6665


Sign in to add a comment

git cl is not helpful if the git remote for a branch is non-Google

Reported by addal...@gmail.com, Jul 6 2017

Issue description

Affected Version: depot_tools master (?)

What steps will reproduce the problem?
1. Create a branch with its `remote` (as in `git config branch.foo.remote` set to e.g. a SSH repository), tracking a branch from that remote
2. Run `git cl upload` or generally anything that triggers `_GerritChangelistImpl.GetCodereviewServer` in `git_cl.py`

What is the expected output?

An error message that says git is not set up correctly.

What do you see instead?

A `Credentials for the following hosts are required` error message followed with the host just given as `-review` (because `self._GetGitHost()` in `GetCodereviewServer` returns an empty string).
 
Gerrit folks: please move this to chromium tracker for Infra>Codereview>Gerrit.

Comment 2 by logan@google.com, Sep 5 2017

Labels: -Type-Bug -Priority-3 Proj-Gerrit-Migration

Comment 3 by logan@google.com, Sep 5 2017

Project: chromium
Moved issue gerrit:6665 to now be  issue chromium:761999 .

Comment 4 by aga...@chromium.org, Sep 11 2017

Status: WontFix (was: New)
Yes, this is true. While we'd love to have "git cl" be generally useful for everyone everywhere, it simply can't be a priority.

Sign in to add a comment