New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761998 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 761994



Sign in to add a comment

Add show_inline field to logos returned by LogoService

Project Member Reported by sfiera@chromium.org, Sep 5 2017

Issue description

Interactive doodles need to inject HTML and JS into the local NTP. Accordingly, LogoService needs to provide that data.

(Accordingly, the doodle server needs to provide that data; it doesn't yet)
 

Comment 1 by fi...@chromium.org, Sep 11 2017

Still targeting M-62? And what's the nature of this report? FR or bug?

Comment 2 by sfiera@chromium.org, Sep 11 2017

Labels: -M-62 M-63 Type-Feature
Labels: zine-triaged

Comment 4 by sfiera@chromium.org, Sep 21 2017

Labels: -M-63 M-64

Comment 5 by treib@chromium.org, Nov 2 2017

Summary: Add show_inline field to logos returned by LogoService (was: Add HTML, JS fields to logos returned by LogoService)
The HTML/JS fields don't exist anymore in the new design. Instead there'll be a "show_inline" flag/enum that decides whether we should show the doodle inline in an iframe, or just link to the fpdoodle.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/835d9ec05fb027b1f371fad42a2c98c0ee687171

commit 835d9ec05fb027b1f371fad42a2c98c0ee687171
Author: Chris Pickel <sfiera@chromium.org>
Date: Tue Nov 07 10:26:33 2017

Update ddljson test data

Updated via script. New data includes:
  * log_url
  * cta_log_url
  * "&source=doodle-ntp" on target_url
  * Some changes to interactive_html, which we don't care about anymore.

Bug:  761998 
Change-Id: I308c4c1227282d4df4421c61fed83b88f1e7ff41
Reviewed-on: https://chromium-review.googlesource.com/753907
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514434}
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_android0.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_android0_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_android1.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_android1_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_android2.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_android2_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_android3.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_android3_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_android4.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_android4_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_desktop0.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_desktop0_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_desktop1.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_desktop1_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_desktop2.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_desktop2_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_desktop3.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_desktop3_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_desktop4.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_desktop4_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_ios0.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_ios0_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_ios1.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_ios1_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_ios2.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_ios2_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_ios3.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_ios3_fp.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_ios4.json
[modify] https://crrev.com/835d9ec05fb027b1f371fad42a2c98c0ee687171/components/test/data/search_provider_logos/ddljson_ios4_fp.json

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 7 2017

Comment 8 by treib@chromium.org, Nov 20 2017

Status: Started (was: Assigned)
I think this one is done?

Comment 9 by treib@chromium.org, Nov 20 2017

Nope, it's not :)
Cc: treib@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cf7b8fc7e25bf89b1afa3066638217643acce54

commit 0cf7b8fc7e25bf89b1afa3066638217643acce54
Author: Chris Pickel <sfiera@chromium.org>
Date: Wed Dec 06 17:01:07 2017

Doodles: handle launch_interactive_behavior

If it's NEW_WINDOW, turn the doodle into a SIMPLE doodle.

Bug:  761998 
Change-Id: Ida81f4dfaf920c42594b76d442403324d3f493ad
Reviewed-on: https://chromium-review.googlesource.com/808972
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522113}
[modify] https://crrev.com/0cf7b8fc7e25bf89b1afa3066638217643acce54/components/search_provider_logos/google_logo_api.cc
[modify] https://crrev.com/0cf7b8fc7e25bf89b1afa3066638217643acce54/components/search_provider_logos/google_logo_api_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment