New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761995 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task

Blocking:
issue 718770



Sign in to add a comment

Cleanup: Remove "forced URLs" from TopSites

Project Member Reported by treib@chromium.org, Sep 5 2017

Issue description

TopSites has a concept of "forced URLs" that it keeps track of. These are URLs that aren't part of the actual TopSites, but for which we still want to capture and store thumbnails. In practice, this is used to get thumbnails for MostLikely suggestions - these are added as forced URLs to TopSites when they show up on the NTP.

Since  bug 514752  (launched in M60), MostLikely suggestions come through Chrome's SuggestionsService, so the whole forced URLs hack isn't necessary anymore - we can just ask the SuggestionsService directly. In particular, TopSites::IsKnownURL would need to check SuggestionsService in addition to its own known URLs.
 

Comment 1 by fi...@chromium.org, Sep 11 2017

Labels: zine-triaged
Status: Assigned (was: Available)

Comment 2 by treib@chromium.org, Oct 13 2017

Labels: -Type-Bug Type-Task
Turns out it's not quite so easy. While TopSites(Impl) itself doesn't really need to know of the forced URLs anymore, TopSitesCache and TopSitesDatabase still do need to keep track of them. So I'm not sure how much can really be saved here.

Comment 3 by treib@chromium.org, Jan 11 2018

Status: WontFix (was: Assigned)

Sign in to add a comment