Show interactive doodles on the Desktop local NTP |
|||||||
Issue descriptionSome doodles have interactive components. These need to be injected into the local NTP. We also need the data to inject. This work will follow non-interactive doodles.
,
Sep 5 2017
,
Sep 5 2017
,
Sep 21 2017
,
Nov 8 2017
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/397e3d5147f289324672402d6948129589fc8e16 commit 397e3d5147f289324672402d6948129589fc8e16 Author: Marc Treib <treib@chromium.org> Date: Wed Nov 08 15:10:47 2017 Local NTP: Adapt CSP child-src to allow the Doodle iframe Bug: 761994 Change-Id: I73d0ad47ed998e03e3ae9a6244a923ed8d16767e Reviewed-on: https://chromium-review.googlesource.com/758756 Reviewed-by: Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#514828} [modify] https://crrev.com/397e3d5147f289324672402d6948129589fc8e16/chrome/browser/search/local_ntp_source.cc
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fc5cd4cf6a49dda35752840d74f2ee146927fae commit 6fc5cd4cf6a49dda35752840d74f2ee146927fae Author: Chris Pickel <sfiera@chromium.org> Date: Fri Nov 10 19:05:38 2017 Local NTP: show INTERACTIVE doodles in <iframe> Bug: 761994 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2083e6afdd444639d7d4141e3305d70d2413c875 Reviewed-on: https://chromium-review.googlesource.com/758760 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#515625} [modify] https://crrev.com/6fc5cd4cf6a49dda35752840d74f2ee146927fae/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/6fc5cd4cf6a49dda35752840d74f2ee146927fae/chrome/browser/resources/local_ntp/local_ntp.html [modify] https://crrev.com/6fc5cd4cf6a49dda35752840d74f2ee146927fae/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/6fc5cd4cf6a49dda35752840d74f2ee146927fae/chrome/browser/search/local_ntp_source.cc [modify] https://crrev.com/6fc5cd4cf6a49dda35752840d74f2ee146927fae/chrome/browser/ui/search/local_ntp_browsertest.cc [modify] https://crrev.com/6fc5cd4cf6a49dda35752840d74f2ee146927fae/chrome/test/data/local_ntp/local_ntp_browsertest.html
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/710dd85c49e2bacd488fae6be533be5a9ce836f0 commit 710dd85c49e2bacd488fae6be533be5a9ce836f0 Author: Marc Treib <treib@chromium.org> Date: Mon Nov 20 15:56:40 2017 Add about:flags choices for interactive test doodles on desktop Bug: 761994 Change-Id: I7eb1f7e457eb3a1d23f734c15ba1dc898ade4e52 Reviewed-on: https://chromium-review.googlesource.com/779423 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#517833} [modify] https://crrev.com/710dd85c49e2bacd488fae6be533be5a9ce836f0/chrome/browser/about_flags.cc
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eefd29205a134cc1240318e0007edb3970b95c94 commit eefd29205a134cc1240318e0007edb3970b95c94 Author: Marc Treib <treib@chromium.org> Date: Tue Nov 21 14:57:14 2017 Local NTP Doodles: Add field trial param for interactive Doodles If this parameter is set to false, then interactive doodles are treated as simple doodles instead. This will allow us to experiment with the local NTP even while support for interactive doodles is still incomplete. Bug: 761994 Change-Id: I14f7079f117a099552f901ccfd37277fbe2c9008 Reviewed-on: https://chromium-review.googlesource.com/779429 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#518241} [modify] https://crrev.com/eefd29205a134cc1240318e0007edb3970b95c94/chrome/browser/search/local_ntp_source.cc
,
Nov 22 2017
I have such issue. the new tab looks like this: http://take.ms/DAPfl In a console, I have such error: http://take.ms/toLlW
,
Nov 22 2017
Thanks for reporting! This is on Chrome 64 Dev or Canary, correct? On those channels, it's expected that things are sometimes broken :) That said, this is clearly not good, and I'll disable this part of the feature again soon.
,
Nov 22 2017
Yes, I use Canary. And also I have an issue with login on some sites. Twitter, for instance. It will be cool if you will fix it
,
Nov 22 2017
Sorry, but that is too unspecific for me to do anything, and it's also unrelated to this bug. Can you please file a new bug at crbug.com/new? In the "new bug" form, pleased provide as much info as possible to help us reproduce the problem, such as: What exactly is the issue? What did you do just before? Do you get any error messages? etc
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ea64714263e9995073ca40574a000cea298d2fd commit 9ea64714263e9995073ca40574a000cea298d2fd Author: Chris Pickel <sfiera@chromium.org> Date: Tue Dec 05 15:38:39 2017 Local NTP: implement Doodle resize API A postMessage call from the doodle resizes the iframe. The event data supports these parameters. cmd (required): must be "resizeDoodle". width (optional): a CSS width (with units) or null. Because the doodle cannot know the size of the outer page, only "100%" (full page width) and null (default width) are recommended. height (optional): a CSS height (with units) or null for the default (200px). Must not be a percentage, but otherwise any units are OK. duration (optional): a CSS duration, such as 130ms or 1s. If null or absent, 0s (no transition) is assumed. If a second resize is requested while a first resize is in in transition, the doodle will eventually reach the size from the second call, but the interpretation of the duration is not defined. Bug: 761994 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9f6afe956e710001a45a9b327748a74eab36ea01 Reviewed-on: https://chromium-review.googlesource.com/804034 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#521700} [modify] https://crrev.com/9ea64714263e9995073ca40574a000cea298d2fd/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/9ea64714263e9995073ca40574a000cea298d2fd/chrome/browser/resources/local_ntp/local_ntp.html [modify] https://crrev.com/9ea64714263e9995073ca40574a000cea298d2fd/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/9ea64714263e9995073ca40574a000cea298d2fd/chrome/test/data/local_ntp/local_ntp_browsertest.html [modify] https://crrev.com/9ea64714263e9995073ca40574a000cea298d2fd/chrome/test/data/local_ntp/voice_browsertest.html
,
Dec 5 2017
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67ffaabe92c68bc68fb8165fde1292f22625a2db commit 67ffaabe92c68bc68fb8165fde1292f22625a2db Author: Chris Pickel <sfiera@chromium.org> Date: Thu Dec 14 09:20:36 2017 Local NTP: use 29px of spacing below logo Brings the Local NTP back in line with the spacing required for certain overly-tall Doodles. Bug: 761994 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7bf8e6aa9e5a3a7035c14b0e1a4c2c2679decc07 Reviewed-on: https://chromium-review.googlesource.com/824239 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#524032} [modify] https://crrev.com/67ffaabe92c68bc68fb8165fde1292f22625a2db/chrome/browser/resources/local_ntp/local_ntp.css
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d9b6266f904f99f36eed48fcb8856bb29767392 commit 3d9b6266f904f99f36eed48fcb8856bb29767392 Author: Marc Treib <treib@chromium.org> Date: Thu Dec 21 14:58:59 2017 Local NTP interactive Doodles: prevent country redirects Bug: 761994 Change-Id: Ic5f84d9e2763ffc5841b0fa6be42344c70afa433 Reviewed-on: https://chromium-review.googlesource.com/839444 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#525690} [modify] https://crrev.com/3d9b6266f904f99f36eed48fcb8856bb29767392/chrome/browser/search/local_ntp_source.cc [modify] https://crrev.com/3d9b6266f904f99f36eed48fcb8856bb29767392/chrome/browser/ui/search/local_ntp_doodle_browsertest.cc
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0bd27773068f186953f828b498c59580ea72d22 commit b0bd27773068f186953f828b498c59580ea72d22 Author: Chris Pickel <sfiera@chromium.org> Date: Wed Jan 10 02:11:33 2018 Local NTP: size Doodle iframe from ddljson Parse iframe_{width,height}_px out of ddljson. Pass it along to the JS. Size the iframe appropriately, and change the margin to preserve the position of the Fakebox. This breaks the previously-functional ability of resizeIframe to specify height: null to reset to the default. Since the Doodle should know its own height, remove that feature instead of fixing it. Bug: 761994 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2c6dd47e046c2c8ab6de087551045429a69d40a6 Reviewed-on: https://chromium-review.googlesource.com/839768 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#528215} [modify] https://crrev.com/b0bd27773068f186953f828b498c59580ea72d22/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/b0bd27773068f186953f828b498c59580ea72d22/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/b0bd27773068f186953f828b498c59580ea72d22/chrome/browser/search/README.md [modify] https://crrev.com/b0bd27773068f186953f828b498c59580ea72d22/chrome/browser/search/local_ntp_source.cc [modify] https://crrev.com/b0bd27773068f186953f828b498c59580ea72d22/components/search_provider_logos/google_logo_api.cc [modify] https://crrev.com/b0bd27773068f186953f828b498c59580ea72d22/components/search_provider_logos/google_logo_api_unittest.cc [modify] https://crrev.com/b0bd27773068f186953f828b498c59580ea72d22/components/search_provider_logos/logo_common.h
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a208ffadb7d7ab8bfacc25618ab12238b7f93748 commit a208ffadb7d7ab8bfacc25618ab12238b7f93748 Author: Marc Treib <treib@chromium.org> Date: Wed Jan 10 10:53:54 2018 search_provider_logos: Initialize LogoMetadata::iframe_width/height_px These fields were introduced in https://crrev.com/c/839768, but not initialized, causing failures on MSan bots. Bug: 761994 Change-Id: I57edd1529f120a76e2cf7c92485744aebea49ac3 Reviewed-on: https://chromium-review.googlesource.com/859378 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#528278} [modify] https://crrev.com/a208ffadb7d7ab8bfacc25618ab12238b7f93748/components/search_provider_logos/logo_common.h
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9abe6892129c07863b70feec866b9f595f68f82a commit 9abe6892129c07863b70feec866b9f595f68f82a Author: Chris Pickel <sfiera@chromium.org> Date: Fri Jan 12 16:22:56 2018 Disable scrolling in Doodle iframe The Doodle we tested with shows them initially before it sizes itself properly. That’s something that could probably be fixed on the Doodles side too, but since they should never be displayed, ensure that on the Chrome side also/instead. R=treib Bug: 761994 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8487e1654ab6302d2146984e258e7e8ec8f8d14a Reviewed-on: https://chromium-review.googlesource.com/862942 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#528961} [modify] https://crrev.com/9abe6892129c07863b70feec866b9f595f68f82a/chrome/browser/resources/local_ntp/local_ntp.html |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sfiera@chromium.org
, Sep 5 2017