Regression: 'Add address' overlay is not seen properly on resizing the browser.
Reported by
dchau...@etouch.net,
Sep 5 2017
|
||||||||||||
Issue descriptionChrome Version: 63.0.3206.0 (Official Build)af90ff1d0f68fc54ba786e37583912bedfc7818c-refs/heads/master@{#499527} 32/64-bit. OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3). What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://settings/autofill 2. Click on 'ADD' button under 'Addresses' section to open 'Add address' overlay. 3. Now, resize the browser from RHS to LHS and observe the 'Add address' overlay. LHS of 'Add address' overlay gets hide on resizing the browser. LHS of 'Add address' overlay should not get hide on resizing the browser. This is a regression issue, broken in M-62 series, below is manual regression range. Good build: 62.0.3201.0 Bad build: 62.0.3202.0 You are probably looking for a change made after 499065 (known good), but no later than 499066 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/bd7b13bd96b4fab786b24cc98cb9c42fd3905e6b..5677b32274aec4890c7dd991a6a84924e65d4853 Suspect: https://chromium.googlesource.com/chromium/src/+/5677b32274aec4890c7dd991a6a84924e65d4853 @scottchen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Kindly review the attached screen-cast for reference.
,
Sep 5 2017
While this IS caused by a recent bugfix for https://crbug.com/760888 , I'm not sure if the behavior in question should be considered a regression or RB-stable. The clipping behavior always, its just shifted recently: Originally in the "expected behavior" video, you're still seeing only the left 50% of the dialog, whereas the "actual behavior" video you're seeing the middle 50% of the dialog. This is due to a change in the logic to center the dialog. If we think clipping anywhere of the dialog is unacceptable, we should make the dialog shrink in width or scroll sideways, instead of shifting it back and hiding 50% of the right-side.
,
Sep 5 2017
,
Sep 5 2017
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5282c59aa39d5ced02eea99766ab471da7351d1e commit 5282c59aa39d5ced02eea99766ab471da7351d1e Author: Scott Chen <scottchen@chromium.org> Date: Wed Sep 06 23:48:05 2017 WebUI: fix cr-dialog bugs related to positioning/pulsing A previous attempt to fix dialog pulsing bug introduced other unexpected issues, so this CL reverts it and approaches the bug in a different way (without using css-transform). Bug: 760888 , 761982 , 761252 , 761244 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib1b11e1d497e2796c7c0804341e3548588bd16c5 Reviewed-on: https://chromium-review.googlesource.com/651576 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#500131} [modify] https://crrev.com/5282c59aa39d5ced02eea99766ab471da7351d1e/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [modify] https://crrev.com/5282c59aa39d5ced02eea99766ab471da7351d1e/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
,
Sep 7 2017
Retested this issue on Windows-(7,8,10) machine using latest Canary build # 63.0.3208.0 (Official Build) and fix is working as expected i.e. LHS of 'Add address' overlay doesn't get hide on resizing the browser. Attaching screen-cast for the same.
,
Sep 7 2017
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/249854ac8778ef30cd5ba302d17ddba0ba611f9f commit 249854ac8778ef30cd5ba302d17ddba0ba611f9f Author: Scott Chen <scottchen@chromium.org> Date: Wed Sep 13 20:57:48 2017 WebUI: fix cr-dialog bugs related to positioning/pulsing A previous attempt to fix dialog pulsing bug introduced other unexpected issues, so this CL reverts it and approaches the bug in a different way (without using css-transform). Bug: 760888 , 761982 , 761252 , 761244 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib1b11e1d497e2796c7c0804341e3548588bd16c5 Reviewed-on: https://chromium-review.googlesource.com/651576 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500131}(cherry picked from commit 5282c59aa39d5ced02eea99766ab471da7351d1e) Reviewed-on: https://chromium-review.googlesource.com/665100 Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#210} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/249854ac8778ef30cd5ba302d17ddba0ba611f9f/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [modify] https://crrev.com/249854ac8778ef30cd5ba302d17ddba0ba611f9f/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
,
Sep 20 2017
Just to Update: Rechecked the above issue on Mac OS with Chrome Beta version :62.0.3202.29 and the issue is not reproducible.Kindly refer the attached screen cast for reference.
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by msrchandra@chromium.org
, Sep 5 2017