Issue metadata
Sign in to add a comment
|
Tools menu is displayed in preview screenshot of report an issue. |
||||||||||||||||||||||
Issue descriptionApp Version: 63.0.3205.0 iOS Version: 9.3.5, 10.3.3, 11.0 Beta 9 Device: iPhone and iPad Steps to reproduce: 1. Launch chrome 2. Go to menu>>Report an issue 3. Tap on next button Observed results: Notice the preview screen is displaying incorrect screenshot Expected results: The screenshot captured for Report an issue should be valid. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M61 Bug reproducible on the current beta channel build (App Version, iOS Version): NA (Beta build is not available for m62, yet the bad build for 62 is identified in canary on 62.0.3200.0) Link to video/image: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8ZTVLTDhlVTZua2M/view?usp=sharing
,
Sep 7 2017
Hey Ed, are you looking into this issue? We aim to fix RBS as soon as possible in the cycle.
,
Sep 11 2017
This isn't related to the snapshot changes. But I can try to debug this.
,
Sep 12 2017
A fix is on it's way! https://chromium-review.googlesource.com/c/chromium/src/+/662405
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6964b655e8b1cf70d19365d885fdccc0bfa64a04 commit 6964b655e8b1cf70d19365d885fdccc0bfa64a04 Author: edchin <edchin@chromium.org> Date: Tue Sep 12 15:34:33 2017 [ios] Fix snapshot when reporting an issue. This CL fixes a bug that was introduced while refactoring IDC_REPORT_AN_ISSUE command. The command execution was originally wrapped in a dispatch_async so as to give enough time for the tools menu to disappear before taking a snapshot of the screen. The refactoring removed this necessary dispatch_async call. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/638840 Bug: 761964 Change-Id: Idf498559c5f6d5963204cb35e7efad5def1d3b81 Reviewed-on: https://chromium-review.googlesource.com/662405 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501285} [modify] https://crrev.com/6964b655e8b1cf70d19365d885fdccc0bfa64a04/ios/chrome/app/main_controller.mm
,
Sep 12 2017
Thanks for the fix, Ed!
,
Sep 12 2017
,
Sep 12 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-62; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-62 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 13 2017
Verified on 63.0.3214.0 Canary on iPhone7(iOS 10.3.3) and iPad Mini(iOS 11.0) Preview screenshot of the Report an issue looks good, no tool bar is seen.
,
Sep 13 2017
Ramesh can you please confirm if this bug is present in M62 or not?
,
Sep 14 2017
This bug still exist in M62, verified on 62.0.3202.23 on iPhone7plus(iOS 10.3.3)
,
Sep 18 2017
This issue is not fixed in M62, therefore changing the status back to fixed. Please look in to it, thanks.
,
Sep 19 2017
Hi Ed, Is a merge needed here for 62?
,
Sep 28 2017
This is still reproducible in M62.0.3202.39. Please merge this into M62.
,
Sep 28 2017
,
Sep 28 2017
This bug requires manual review: Less than 15 days to go before AppStore submit on M62 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 28 2017
,
Sep 29 2017
Verified the issue on the build 63.0.3226.0 canary tested on iPhone7+(11.0). Menu screen is not shown in report an issue screen,looks good.
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae8ee2cdb2407ffafcf3af876d0d6a46956ebce8 commit ae8ee2cdb2407ffafcf3af876d0d6a46956ebce8 Author: edchin <edchin@chromium.org> Date: Fri Sep 29 16:58:41 2017 [ios] Fix snapshot when reporting an issue. This CL fixes a bug that was introduced while refactoring IDC_REPORT_AN_ISSUE command. The command execution was originally wrapped in a dispatch_async so as to give enough time for the tools menu to disappear before taking a snapshot of the screen. The refactoring removed this necessary dispatch_async call. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/638840 Bug: 761964 Change-Id: Idf498559c5f6d5963204cb35e7efad5def1d3b81 Reviewed-on: https://chromium-review.googlesource.com/662405 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501285}(cherry picked from commit 6964b655e8b1cf70d19365d885fdccc0bfa64a04) Reviewed-on: https://chromium-review.googlesource.com/692555 Cr-Commit-Position: refs/branch-heads/3202@{#509} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/ae8ee2cdb2407ffafcf3af876d0d6a46956ebce8/ios/chrome/app/main_controller.mm
,
Oct 4 2017
Verified on 62.0.3202.44 Beta build in iPad Air(iOS11) and iPhone7(iOS10.3.3) Tools menu is not displayed in preview screenshot of Report an issue |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sczs@chromium.org
, Sep 6 2017Labels: ReleaseBlock-Stable M-62
Owner: edchin@chromium.org
Status: Assigned (was: Untriaged)