New issue
Advanced search Search tips

Issue 761960 link

Starred by 1 user
Status: Fixed
Owner:
dullweber@chromium.org
Closed: Sep 2017
Cc:
msramek@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

ProfileStatistics are calculated every time settings are opened

Project Member Reported by dullweber@chromium.org, Sep 5 2017 
Chrome Version: HEAD

What steps will reproduce the problem?
(1) open settings

What is the expected result?
settings.ProfileInfoBrowserProxyImpl.getInstance().getProfileStatsCount() 
should only be called when signing out.

What happens instead?
profile statistics are calculated every time settings are opened. 

https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/people_page.js?l=234&rcl=a7a788faafe45c3f9eb79029a29adfab14917a76

The call to fetch stats was moved from only being executed for the signout route to always execute when sync status changes:
https://codereview.chromium.org/2614883004/diff/60001/chrome/browser/resources/settings/people_page/people_page.js
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a22d04e7765ccf6fde92528ab91b022c452c5ddb

commit a22d04e7765ccf6fde92528ab91b022c452c5ddb
Author: Christian Dullweber <dullweber@chromium.org>
Date: Wed Sep 06 09:56:08 2017

Only calculate profile statistics on signout

This changes people_page.js to only call getProfileStatsCount()
when a user actually tries to sign out. Previously it was called
every time settings are opened.

Bug:  761960 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iddf2b104f6d315b9d089cea4919e1a37d8124893
Reviewed-on: https://chromium-review.googlesource.com/650346
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499921}
[modify] https://crrev.com/a22d04e7765ccf6fde92528ab91b022c452c5ddb/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/a22d04e7765ccf6fde92528ab91b022c452c5ddb/chrome/test/data/webui/settings/people_page_test.js

Comment 2 by dullweber@chromium.org, Sep 6 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment