New issue
Advanced search Search tips

Issue 761952 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK failed when turning of sync after using clear browsing data

Project Member Reported by dullweber@chromium.org, Sep 5 2017

Issue description

Chrome Version: HEAD
OS: linux

What steps will reproduce the problem?
(0) be signed in and syncing
(1) go to chrome://md-settings/clearBrowserData
(2) cancel dialog
(3) go to sync settings
(4) turn of "sync everything"
(5) click back arrow

What is the expected result?
I'm back in settings

What happens instead?
Chrome crashes with a failed DCHECK

[177027:177027:0905/111948.853313:FATAL:browsing_data_counter.cc(103)] Check failed: false. 
#0 0x7ff2d529c4b7 base::debug::StackTrace::StackTrace()
#1 0x7ff2d52c3271 logging::LogMessage::~LogMessage()
#2 0x563e757599ed browsing_data::BrowsingDataCounter::ReportResult()
#3 0x563e7575accb browsing_data::PasswordsCounter::OnGetPasswordStoreResults()
#4 0x563e74bd5531 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN16password_manager21PasswordStoreConsumerEFvNSt3__16vectorINS6_10unique_ptrIN8autofill12PasswordFormENS6_14default_deleteISA_EEEENS6_9allocatorISD_EEEEERKNS_7WeakPtrIS5_EEJSG_EEEvOT_OT0_DpOT1_
#5 0x563e74bd53ca _ZN4base8internal7InvokerINS0_9BindStateIMN16password_manager21PasswordStoreConsumerEFvNSt3__16vectorINS5_10unique_ptrIN8autofill12PasswordFormENS5_14default_deleteIS9_EEEENS5_9allocatorISC_EEEEEJNS_7WeakPtrIS4_EENS0_13PassedWrapperISF_EEEEEFvvEE7RunImplIRKSH_RKNS5_5tupleIJSJ_SL_EEEJLm0ELm1EEEEvOT_OT0_NS5_16integer_sequenceImJXspT1_EEEE


 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce7491a22d430792718c1d6f1d3c306b2cda4c76

commit ce7491a22d430792718c1d6f1d3c306b2cda4c76
Author: Christian Dullweber <dullweber@chromium.org>
Date: Tue Sep 05 15:25:23 2017

Prevent password results to be reported after another run is started

CancelableTaskTracker doesn't completely prevent getting an old result, 
so also delete the weakptr to avoid cases where two results are 
reported in a row.

Bug:  761952 
Change-Id: I727ea76c455c260a7db0e048b2e9e3d9e69069ed
Reviewed-on: https://chromium-review.googlesource.com/649529
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499640}
[modify] https://crrev.com/ce7491a22d430792718c1d6f1d3c306b2cda4c76/chrome/browser/ui/passwords/password_manager_presenter.cc
[modify] https://crrev.com/ce7491a22d430792718c1d6f1d3c306b2cda4c76/components/browsing_data/core/counters/passwords_counter.cc
[modify] https://crrev.com/ce7491a22d430792718c1d6f1d3c306b2cda4c76/components/password_manager/core/browser/password_store_consumer.cc
[modify] https://crrev.com/ce7491a22d430792718c1d6f1d3c306b2cda4c76/components/password_manager/core/browser/password_store_consumer.h

Status: Fixed (was: Untriaged)

Sign in to add a comment