New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761946 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
(OOO slow)
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 765462



Sign in to add a comment

ContextualSearchManagerTest#testNetworkDisconnectedDeactivatesSearch is flaky

Project Member Reported by dgn@chromium.org, Sep 5 2017

Issue description

It seems to have been flaking forever on chromium.android.

junit.framework.AssertionFailedError: Panel did not enter PEEKED state. Instead, the current state is UNDEFINED.
	at junit.framework.Assert.fail(Assert.java:50)
	at junit.framework.Assert.assertTrue(Assert.java:20)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToEnterState(ContextualSearchManagerTest.java:821)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToPeek(ContextualSearchManagerTest.java:788)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.testNetworkDisconnectedDeactivatesSearch(ContextualSearchManagerTest.java:2924)


Links
- Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest%23testNetworkDisconnectedDeactivatesSearch
- Sample build: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/9672
 

Comment 1 by dgn@chromium.org, Sep 5 2017

Description: Show this description

Comment 2 by dgn@chromium.org, Sep 5 2017

Components: -UI>Browser>Contextual>Search UI>Browser>Mobile>TouchToSearch
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74db6e0ab43481e24fab99abd95597f71801bbf1

commit 74db6e0ab43481e24fab99abd95597f71801bbf1
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Tue Sep 05 09:52:24 2017

Disable flaky testNetworkDisconnectedDeactivatesSearch

The flakiness rate triggers too many failures even through
the retries.


TBR=donnd@chromium.org

Bug: 761946
Change-Id: Ic1d47d8ba094526b7516bce5df4740b21f1fc29a
Reviewed-on: https://chromium-review.googlesource.com/649689
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499594}
[modify] https://crrev.com/74db6e0ab43481e24fab99abd95597f71801bbf1/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Comment 4 by donnd@google.com, Sep 14 2017

Blocking: 765462

Comment 5 by donnd@google.com, Nov 8 2017

Components: Tests>Disabled
Components: Tests>Disabled
Labels: Test-Disabled
Cc: linds...@chromium.org
Labels: Hotlist-DisableReview
@donnd can you ptal at this disable as it reduces automated test coverage?

Sign in to add a comment