Attached output

Deleted: log.txt 12.3 KB

log.txt 12.3 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bf7e3c60ca30098a13cc9659514496bee9fc555

commit 4bf7e3c60ca30098a13cc9659514496bee9fc555
Author: Christos Froussios <cfroussios@chromium.org>
Date: Tue Sep 05 08:27:22 2017

Revert "CHR-6375: [Windows] Fixed crash on fallback from ANGLE to SwiftShader."

This reverts commit 21328491476dcf313bd0d68387edf378aad8c19c.

Reason for revert: Suspected of breaking GpuHostTest.GpuClientDestructionOrder
on Builder: Linux Chromium OS ASan LSan Tests
 crbug.com/761930 

Original change's description:
> CHR-6375: [Windows] Fixed crash on fallback from ANGLE to SwiftShader.
> 
> During fallback from ANGLE to SwiftShader it is required to unload
> ANGLE libraries, otherwise SwiftShader will fail to load its own
> libGLESv2.dll.
> 
> Fixed ANGLE platform reset.
> 
> Bug:  760063 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I02280b2c1cd6c3d81087c7e2befb412bb2a89510
> Reviewed-on: https://chromium-review.googlesource.com/640992
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#499529}

TBR=jmadill@chromium.org,piman@chromium.org,mpichlinski@opera.com

Change-Id: I6d00ee495a9f4efdf03dd6be8aa15426241548a1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  760063 , 761930 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/650286
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499583}
[modify] https://crrev.com/4bf7e3c60ca30098a13cc9659514496bee9fc555/ui/gl/angle_platform_impl.cc
[modify] https://crrev.com/4bf7e3c60ca30098a13cc9659514496bee9fc555/ui/gl/gl_implementation.cc

 Issue 761889  has been merged into this issue.

Reverting appears to have fixed the waterfall failures.

Hi Christos!

Do you know what gn args are used for building OS ASan LSan Tests and how tests are being run?

I've build services_unittests at commit: e45d5c6fb1a9 (first failing commit) with:
is_asan = true
is_lsan = true
is_debug = false
enable_nacl = false
enable_full_stack_frames_for_profiling = true

And running tests with:
G_SLICE=always-malloc NSS_DISABLE_UNLOAD=1 NSS_DISABLE_ARENA_FREE_LIST=1 ASAN_OPTIONS="detect_leaks=1" out/lsanRelease/services_unittests --brave-new-test-launcher  --cfi-diag=0 --test-launcher-print-test-stdio=always --test-launcher-batch-limit=1 --no-sandbox --gtest_filter="GpuHostTest.GpuClientDestructionOrder"

Locally, test passes and Leak Sanitizer does not report any leak.

When I'm running base_unittests ToolsSanityTest.MemoryLeak with same environment sanitizer reports a leak.


I'm on Ubuntu 17.04

I don't know anything specific about your CL or the bot that ran it.

An infra person should be able to dig out the configuration of the bots. I recommend reaching out on IRC or filing a new bug with this specific question to be picked up by the infra team

I didn't mean to add infra here, since the bug is too likely be ignored -_-

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fe0ca099575f8dd90444bcadbb409007e9a547b

commit 9fe0ca099575f8dd90444bcadbb409007e9a547b
Author: Michał Pichliński <mpichlinski@opera.com>
Date: Fri Sep 15 22:32:42 2017

CHR-6375: Fixed crash on fallback from ANGLE to SwiftShader.

During fallback from ANGLE to SwiftShader it is required to unload
ANGLE libraries, otherwise SwiftShader will fail to load its own
libGLESv2 library.

Fixed ANGLE platform reset.

Fixed memory leak on X11 by fixing order in ShutdownGL.

Leak was occuring during fallback from libGL to software GL implementation
because ShutdownGL was cleaning GL implementation info before unloading
GL and therefore libGL was unloaded with known issue crbug.com/250813

Previous attempt with memory leak:
https://chromium-review.googlesource.com/640992

Reverted in:
https://chromium-review.googlesource.com/650286

Bug:  760063 ,  761930 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibea80f560aa50ba48cbff6f39a664095db38daaf
Reviewed-on: https://chromium-review.googlesource.com/668357
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502409}
[modify] https://crrev.com/9fe0ca099575f8dd90444bcadbb409007e9a547b/ui/gl/angle_platform_impl.cc
[modify] https://crrev.com/9fe0ca099575f8dd90444bcadbb409007e9a547b/ui/gl/gl_implementation.cc
[modify] https://crrev.com/9fe0ca099575f8dd90444bcadbb409007e9a547b/ui/gl/init/gl_factory.cc

Even with additional fix in ShutdownGL, memory leak still occurs on Linux Chromium OS ASan LSan Tests, please revert 9fe0ca099575f8dd90444bcadbb409007e9a547b

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6864b6e6f970dae48adc5131f3ca1204b7ea2475

commit 6864b6e6f970dae48adc5131f3ca1204b7ea2475
Author: Max Morin <maxmorin@chromium.org>
Date: Mon Sep 18 11:16:26 2017

Revert "CHR-6375: Fixed crash on fallback from ANGLE to SwiftShader."

This reverts commit 9fe0ca099575f8dd90444bcadbb409007e9a547b.

Reason for revert: Still breaking GpuHostTest.GpuClientDestructionOrder
on Builder: Linux Chromium OS ASan LSan Tests.
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/23657:
[       OK ] GpuHostTest.GpuClientDestructionOrder (100 ms)
[----------] 1 test from GpuHostTest (100 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (100 ms total)
[  PASSED  ] 1 test.
=================================================================
==31215==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x540cf3 in __interceptor_malloc (/b/s/w/ir/out/Release/services_unittests+0x540cf3)
    #1 0x7f979021987f in XextAddDisplay src/extutil.c:106
Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x540cf3 in __interceptor_malloc (/b/s/w/ir/out/Release/services_unittests+0x540cf3)
    #1 0x7f979021980d in XextCreateExtension src/extutil.c:68
    #2 0x621000030cff  (<unknown module>)
Indirect leak of 67200 byte(s) in 300 object(s) allocated from:
    #0 0x540cf3 in __interceptor_malloc (/b/s/w/ir/out/Release/services_unittests+0x540cf3)
    #1 0x7f97835ca364  (<unknown module>)
Indirect leak of 8288 byte(s) in 2 object(s) allocated from:
    #0 0x540cf3 in __interceptor_malloc (/b/s/w/ir/out/Release/services_unittests+0x540cf3)
    #1 0x7f97835ccc2d  (<unknown module>)
Indirect leak of 299 byte(s) in 1 object(s) allocated from:
    #0 0x540cf3 in __interceptor_malloc (/b/s/w/ir/out/Release/services_unittests+0x540cf3)
    #1 0x7f97835aaae3  (<unknown module>)
Indirect leak of 249 byte(s) in 3 object(s) allocated from:
    #0 0x540cf3 in __interceptor_malloc (/b/s/w/ir/out/Release/services_unittests+0x540cf3)
    #1 0x7f97835c8f7f  (<unknown module>)
Indirect leak of 224 byte(s) in 1 object(s) allocated from:
    #0 0x540eea in __interceptor_calloc (/b/s/w/ir/out/Release/services_unittests+0x540eea)
    #1 0x7f97835c96e6  (<unknown module>)
Indirect leak of 112 byte(s) in 1 object(s) allocated from:
    #0 0x540eea in __interceptor_calloc (/b/s/w/ir/out/Release/services_unittests+0x540eea)
    #1 0x7f97835aa331  (<unknown module>)
Indirect leak of 104 byte(s) in 1 object(s) allocated from:
    #0 0x540cf3 in __interceptor_malloc (/b/s/w/ir/out/Release/services_unittests+0x540cf3)
    #1 0x7f97835d1b51  (<unknown module>)
Indirect leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x540cf3 in __interceptor_malloc (/b/s/w/ir/out/Release/services_unittests+0x540cf3)
    #1 0x7f979021987f in XextAddDisplay src/extutil.c:106
Indirect leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x540cf3 in __interceptor_malloc (/b/s/w/ir/out/Release/services_unittests+0x540cf3)
    #1 0x7f97835c9d1d  (<unknown module>)
Indirect leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x540cf3 in __interceptor_malloc (/b/s/w/ir/out/Release/services_unittests+0x540cf3)
    #1 0x7f97835aa4b3  (<unknown module>)
-----------------------------------------------------
Suppressions used:
  count      bytes template
    123      22299 swrast_dri.so
-----------------------------------------------------
SUMMARY: AddressSanitizer: 76588 byte(s) leaked in 314 allocation(s).

Original change's description:
> CHR-6375: Fixed crash on fallback from ANGLE to SwiftShader.
> 
> During fallback from ANGLE to SwiftShader it is required to unload
> ANGLE libraries, otherwise SwiftShader will fail to load its own
> libGLESv2 library.
> 
> Fixed ANGLE platform reset.
> 
> Fixed memory leak on X11 by fixing order in ShutdownGL.
> 
> Leak was occuring during fallback from libGL to software GL implementation
> because ShutdownGL was cleaning GL implementation info before unloading
> GL and therefore libGL was unloaded with known issue crbug.com/250813
> 
> Previous attempt with memory leak:
> https://chromium-review.googlesource.com/640992
> 
> Reverted in:
> https://chromium-review.googlesource.com/650286
> 
> Bug:  760063 ,  761930 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Ibea80f560aa50ba48cbff6f39a664095db38daaf
> Reviewed-on: https://chromium-review.googlesource.com/668357
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#502409}

TBR=jmadill@chromium.org,piman@chromium.org,mpichlinski@opera.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  760063 ,  761930 
Change-Id: I3e286b7b7ce6aa97ab2b8e412f490ad4498d1f7b
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/670705
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502551}
[modify] https://crrev.com/6864b6e6f970dae48adc5131f3ca1204b7ea2475/ui/gl/angle_platform_impl.cc
[modify] https://crrev.com/6864b6e6f970dae48adc5131f3ca1204b7ea2475/ui/gl/gl_implementation.cc
[modify] https://crrev.com/6864b6e6f970dae48adc5131f3ca1204b7ea2475/ui/gl/init/gl_factory.cc