New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761910 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regreesion : Sad face icon is not seen in tab's title bar when tab gets crashed.

Reported by avsha...@etouch.net, Sep 5 2017

Issue description

Chrome version : 63.0.3206.0 (Official Build) af90ff1d0f68fc54ba786e37583912bedfc7818c-refs/heads/master@{#499527} 32/64 bit
OS : Windows(7,8,10), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, open NTP, type chrome://kill in omnibox and hit Enter.
2. Observe the tab icon in tab strip.  

Actual Result : Sad face icon is not seen in tab's title bar when tab is crashed.

Expected Result : Sad face icon should appear in tab's title bar when tab gets killed.

This is a regression issue broken in ‘M-62’and will soon update bisect info.
 
Actual_Result.mp4
1.1 MB View Download
Labels: hasbisect-per-revision
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:62.0.3200.0(Revision:498322).
Bad build:62.0.3201.0(Revision:498715).

You are probably looking for a change made after 498489 (known good), but no later than 498490 (first known bad).

CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/0cb75ffabe51a26775dd5879fda79a565cd2d3b4..a4d6510204bf83d96f7bbcd40ecdbe919ec6d61b

From the CL above, assigning the issue to the concern owner

Suspect : https://chromium.googlesource.com/chromium/src/+/a4d6510204bf83d96f7bbcd40ecdbe919ec6d61b

@estade : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note : Above issue is not reproducible on Mac(10.11.6, 10.12.3, 10.12.5) OS.
Expected_Result.mp4
1.3 MB View Download
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Description: Show this description
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30985d1a07b6af0fe9b9362c8b075c12b70a5483

commit 30985d1a07b6af0fe9b9362c8b075c12b70a5483
Author: Evan Stade <estade@chromium.org>
Date: Wed Sep 06 18:07:16 2017

Restore broken tab crashed icon animation.

Bug:  761910 
Change-Id: I1182e7651e75115d906990357d772439f9a4057d
Reviewed-on: https://chromium-review.googlesource.com/653497
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500009}
[modify] https://crrev.com/30985d1a07b6af0fe9b9362c8b075c12b70a5483/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/30985d1a07b6af0fe9b9362c8b075c12b70a5483/chrome/browser/ui/views/tabs/tab.h

Labels: Merge-Request-62
Labels: TE-Verified-M63 TE-Verified-63.0.3208.0
Update : 
Retested above issue in latest chrome canary #63.0.3208.0 on Windows(7,8,10) & Linux(14.04 LTS) OS and issue is fixed now. Sad face icon is observed properly on crashed tab and it is working as intended.
Kindly review an attached screen cast.

Thank you!
Canary_behavior.mp4
890 KB View Download
Verified the issue on windows 7 , ubuntu 14.04 using chrome M63 #63.0.3208.0 and issue seems fixed.

Sad face icon is seen in tab's title bar when tab is crashed.

Attached screencast for reference.

Adding Te-verified labels.

Thanks!
761910.mp4
219 KB View Download
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 7 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
estade@, could you please merge in to M62 branch as the fix is verified in ToT build.
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 7 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53f831cc0a4e9672c2fb14b78963e68db485fa6b

commit 53f831cc0a4e9672c2fb14b78963e68db485fa6b
Author: Evan Stade <estade@chromium.org>
Date: Thu Sep 07 20:51:22 2017

Restore broken tab crashed icon animation.

TBR=estade@chromium.org

(cherry picked from commit 30985d1a07b6af0fe9b9362c8b075c12b70a5483)

Bug:  761910 
Change-Id: I1182e7651e75115d906990357d772439f9a4057d
Reviewed-on: https://chromium-review.googlesource.com/653497
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500009}
Reviewed-on: https://chromium-review.googlesource.com/655816
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#69}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/53f831cc0a4e9672c2fb14b78963e68db485fa6b/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/53f831cc0a4e9672c2fb14b78963e68db485fa6b/chrome/browser/ui/views/tabs/tab.h

Status: Verified (was: Started)
Labels: TE-Verified-M62 TE-Verified-62.0.3202.18
Verified above issue in latest Dev#62.0.3202.18 build on Windows(7,8,10) & Linux(14.04) OS and issue seems fixed. Sad face icon appears in tab's title bar when tab is crashed. Kindly review an attached screen cast.

Thank you!
Current_behavior.mp4
881 KB View Download

Sign in to add a comment