New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761908 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Regression:Expiration date section drop-downs gets closed immediately on clicking in chrome://settings/autofill page

Project Member Reported by rkalavakuntla@chromium.org, Sep 5 2017

Issue description

Chrome Version:62.0.3202.7/9901.3.0 dev-channel Kip,Daisy,Minnie
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user ->Enable 'On-Screen Keyboard'->Goto chrome://settings/autofill
(2)Click on ADD button near Credit cards ->click on date drop-down near Expiration date and Observe(please refer video)

Expected:Expiration date Dropdown should be seen
Actual:Instead, drop-downs gets closed immediately

This is a Regression issue as same is working fine in 61.0.3163.70/9765.48.0 beta channel Kip

Note:Issue is not seen in Linux,Windows OS

@stevenjb: Please confirm the issue 



 
Actual.webm
485 KB View Download
Expected.webm
538 KB View Download
Cc: michae...@chromium.org
Components: UI>Accessibility
Owner: hcarmona@chromium.org
I can reproduce this on a recent ToT build (9/1) but not on 61.0.3163.70.

Once the on screen keyboard disappears, the dropdown menu seems to work as expected.

hcarmona@ - Any thoughts?
Owner: steve...@chromium.org
Not settings related, not sure who to assign this to.

Able to reproduce in minimal select/option example, check out:
http://output.jsbin.com/caxakexazi
Perhaps a CL can be identified using bisect-builds.py, assuming that the on-screen keyboard is available on ChromeOS on Linux. Something as follows:

./tools/bisect-builds.py -b <bad_revision> -g <good_revision> -a chromeos --user-data-dir=/tmp/debug
Labels: -Pri-1 Pri-2
Owner: ----
Status: Untriaged (was: Assigned)
Clicking the dropdown a second time works OK, so this is not urgent, and as mentioned is not likely Settings specific.

-> a11y triage

Any update on this? We are planning a stable RC next week and this bug is marked as a blocker.

Whom is the right owner here?
Any update on this one? We are planning to build a R62 stable RC the evening of the 19th, so we would need to have all fixes merged back to 62 in ~24 hours. 
Cc: abodenha@chromium.org
Labels: -Pri-2 Pri-0
Upping priority as we build the R62 stable RC tomorrow, we need a fix in the next 24 hours.
Components: -UI>Accessibility -UI>Settings UI>Input>VirtualKeyboard Blink>Editing
Labels: -Pri-0 -ReleaseBlock-Stable Pri-1
Based on #4 I'm removing RBS here.

This sounds like an interaction between VK and selections. Retagging components to get this in front of people who can do something about it.

Comment 9 by yosin@chromium.org, Oct 25 2017

Components: -Blink>Editing
Remove Blink>Editing since drop-downs == SELECT element which isn't related to
selection.

It seems showing virtual keyboard makes popup window == drop-down menu confusion.
drop-down menu window may appear outside window. 
Owner: yhanada@chromium.org
Status: Started (was: Untriaged)
A similar issue ( crbug.com/756554 ) is filed. I will take a look.
Owner: shend@chromium.org
shend@ is looking at this issue now. Thanks!

I wrote that  crbug.com/756554  was similar to this issue, but it seems to have a different cause. 
It seems like hiding the virtual keyboard sends a resize message [1], which causes popups to hide [2]. One solution is to somehow detect this case and not hide the popups.

[1] https://cs.chromium.org/chromium/src/ui/keyboard/keyboard_controller.cc?type=cs&l=354
[2] https://cs.chromium.org/chromium/src/content/renderer/render_view_impl.cc?type=cs&q=OnResize+hidepopups&l=2056
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36f4d544f37aec38256e4daeeef70228ad0a0436

commit 36f4d544f37aec38256e4daeeef70228ad0a0436
Author: Darren Shen <shend@chromium.org>
Date: Mon Feb 12 04:45:15 2018

[VK] Don't hide popups when resizing to the same size.

Currently, clicking on a dropdown when the VK is active will cause
the VK to hide, which sends out a resize message to RenderViewImpl,
which then forces the newly opened dropdown to hide again.

The resize message sent by the VK doesn't actually change the size,
so we can prevent the popup from hiding if the new requested size
is the same as the old. The hope is that this doesn't affect any
other existing behaviour.

Bug:  761908 
Change-Id: I0d2d7e876b42cced2be867ebc5ad3432a4d045c7
Reviewed-on: https://chromium-review.googlesource.com/909869
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536028}
[modify] https://crrev.com/36f4d544f37aec38256e4daeeef70228ad0a0436/content/renderer/render_view_impl.cc

Comment 14 by shend@chromium.org, Feb 12 2018

Status: Fixed (was: Started)

Sign in to add a comment