The spec has been modified and the gutter properties are not reset anymore by the "grid" shorthand. We should update our implementation. CSS WG resultion: https://github.com/w3c/csswg-drafts/issues/1696 Changes on the spec: https://github.com/w3c/csswg-drafts/commit/8f243616df9b967ae546459e955ce0186188b54b
The spec has been modified and the gutter properties are not reset anymore by the "grid" shorthand. We should update our implementation. CSS WG resultion: https://github.com/w3c/csswg-drafts/issues/1036 Changes on the spec: https://github.com/w3c/csswg-drafts/commit/8f243616df9b967ae546459e955ce0186188b54b
Firefox is planning to modify their implementation too: https://bugzilla.mozilla.org/show_bug.cgi?id=1387410
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/850c817c6a46e5b3a420c02898e2adc2376d91fc commit 850c817c6a46e5b3a420c02898e2adc2376d91fc Author: Manuel Rego Casasnovas <rego@igalia.com> Date: Wed Sep 06 08:10:06 2017 [css-grid] grid shorthand does not reset gutter properties The CSS WG has resolved that the "grid" shorthand shouldn't reset the gutter properties anymore: https://github.com/w3c/csswg-drafts/issues/1036 This was originally implemented in r370102, so this is somehow a revert of that change. The patch adds a new test to WPT verifying the expected behavior. BUG= 761905 TEST=external/wpt/css/css-grid-1/grid-definition/grid-shorthand-001.html Change-Id: Ib8b0591a0132c6520c3cfd8f13fb2cf2a33e1be0 Reviewed-on: https://chromium-review.googlesource.com/650406 Reviewed-by: Sergio Villar <svillar@igalia.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: meade_UTC10 <meade@chromium.org> Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#499901} [add] https://crrev.com/850c817c6a46e5b3a420c02898e2adc2376d91fc/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/grid-definition/grid-shorthand-001.html [modify] https://crrev.com/850c817c6a46e5b3a420c02898e2adc2376d91fc/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt [modify] https://crrev.com/850c817c6a46e5b3a420c02898e2adc2376d91fc/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html [modify] https://crrev.com/850c817c6a46e5b3a420c02898e2adc2376d91fc/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-property-listing-expected.txt [modify] https://crrev.com/850c817c6a46e5b3a420c02898e2adc2376d91fc/third_party/WebKit/LayoutTests/webexposed/css-property-listing-expected.txt [modify] https://crrev.com/850c817c6a46e5b3a420c02898e2adc2376d91fc/third_party/WebKit/Source/core/css/CSSProperties.json5 [modify] https://crrev.com/850c817c6a46e5b3a420c02898e2adc2376d91fc/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIGrid.cpp
Comment 1 by r...@igalia.com
, Sep 5 2017