MidiManagerAndroid: use PackageManager to detect MIDI feature support |
||||||
Issue descriptionExisting code just checks Android version to know if the system supports Android MIDI API, but reality is it depends on products. This patch introduces an additional check to ask PackageManager. This is expected to work always because cts would requre MIDI tests to pass if it says FEATURE_MIDI is supported on the device. See aosp-master/cts/tests/tests/midi/src/android/midi/cts/MidiEchoTest.java
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb9d4e928c253ced50305e296b2433949845df07 commit cb9d4e928c253ced50305e296b2433949845df07 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Tue Sep 05 06:30:58 2017 MidiManagerAndroid: use PackageManager to detect MIDI feature support Existing code just checks Android version to know if the system supports Android MIDI API, but reality is it depends on products. This patch introduces an additional check to ask PackageManager. This is expected to work always because cts would requre MIDI tests to pass if it says FEATURE_MIDI is supported on the device. See aosp-master/cts/tests/tests/midi/src/android/midi/cts/MidiEchoTest.java Bug: 486584, 683027, 761897 Change-Id: Idb3ca57c3179220957dd16126f24570e2b45f299 Reviewed-on: https://chromium-review.googlesource.com/643246 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#499575} [modify] https://crrev.com/cb9d4e928c253ced50305e296b2433949845df07/media/midi/java/src/org/chromium/midi/MidiManagerAndroid.java [modify] https://crrev.com/cb9d4e928c253ced50305e296b2433949845df07/media/midi/midi_manager_android.cc
,
Sep 5 2017
,
Sep 6 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2017
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63d9afafc8e7d31754da3632ef8d05d623f16581 commit 63d9afafc8e7d31754da3632ef8d05d623f16581 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Wed Sep 06 09:50:13 2017 MidiManagerAndroid: use PackageManager to detect MIDI feature support Existing code just checks Android version to know if the system supports Android MIDI API, but reality is it depends on products. This patch introduces an additional check to ask PackageManager. This is expected to work always because cts would requre MIDI tests to pass if it says FEATURE_MIDI is supported on the device. See aosp-master/cts/tests/tests/midi/src/android/midi/cts/MidiEchoTest.java (cherry picked from commit cb9d4e928c253ced50305e296b2433949845df07) Bug: 486584, 683027, 761897 Change-Id: Idb3ca57c3179220957dd16126f24570e2b45f299 Reviewed-on: https://chromium-review.googlesource.com/643246 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499575} Reviewed-on: https://chromium-review.googlesource.com/652186 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#40} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/63d9afafc8e7d31754da3632ef8d05d623f16581/media/midi/java/src/org/chromium/midi/MidiManagerAndroid.java [modify] https://crrev.com/63d9afafc8e7d31754da3632ef8d05d623f16581/media/midi/midi_manager_android.cc
,
Sep 6 2017
62.0.3202.10 will pick it up. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by toyoshim@chromium.org
, Sep 5 2017