New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761886 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

"Turn off display and sleep" width is too short for translated strings.

Project Member Reported by uekawa@chromium.org, Sep 5 2017

Issue description

Chrome Version: 61.0.3163.70, 63.0.3203.0
OS: Chrome OS

What steps will reproduce the problem?
(1) open power settings chrome://settings/power
(2) observe the "When idle" configuration

What is the expected result?
Be able to tell what the current configuration is

What happens instead?
The current configuration string is cut off.



The translated strings should be shorter (and there should be an instruction about the space limitation) or the space should be larger ?

(I believe the string is 
tc/btviewer/messagedetail?project=ChromeClient&msgId=8061686391094850746
I suspect for about half of the languages the space is too narrow.
)

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Screenshot 2017-09-05 at 11.50.45.png
23.2 KB View Download
For the benefit of those who can't read Japanese, the sentence is cut halfway and does not have the most important part, so it's hard to tell whether it does sleep or it doesn't.


Comment 2 by derat@chromium.org, Sep 5 2017

Cc: steve...@chromium.org michae...@chromium.org
Components: UI>Internationalization
Michael/Steven, do either of you have thoughts here? Has this been an issue elsewhere?

Junichi, is there an alternate translation (i.e. using less katakana) that would be more likely to fit?
Labels: OS-Chrome
Status: Assigned (was: Untriaged)
The string is IDS_SETTINGS_POWER_IDLE_DISPLAY_OFF_SLEEP

The description for it says "menu item" which should be an indicator that the string needs to be relatively short.

If shortening this is problematic, my suggestion would be:
1. Add descriptive text for each selection with a shorter menu entries (e.g. just 'Sleep')
2. Make the enclosing 'settings-box' div 'settings-box two-line'
3. Add a 'secondary' line with the longer description based on the selected option (e.g see 'displayLayout' inn display.html in that directory)
 
Labels: -Pri-3 Pri-2
I'm surprised that <select>s don't have a hover tooltip when the text overflows. (Overflow is hard to detect from JS, so maybe we could just add a "title" attribute to md-select whenever the select is disabled to be safe.)

See example attached.
title.png
68.9 KB View Download
Cc: hcarmona@chromium.org
+hcarmona may have ideas from a11y land.
From an A11y point, a select with long text works well with screen readers, and not so well with zoom.

Setting the title would be good for zooming in and reading the text, but will read the title and selection in a screen reader. Since they're the same, we'll be creating noise which is not ideal.

I don't think a tooltip is the best approach here because it also requires hovering over the control to get the full meaning which will slow down any user of this UI who needs to read the full text.

The best fix here would be shorter translations or making our select's wider, IMO.

Comment 7 by uekawa@google.com, Sep 6 2017

Re #2, I would think for Japanese I can think of something creative, but from tc/ about half of the languages probably don't fit and the rest needs also be taken care of.

Comment 8 by derat@chromium.org, Sep 6 2017

Cc: jennschen@chromium.org
Right now, the three options are:

* Turn off display and sleep
* Turn off display
* Keep display on

Jenn, I know we spend forever deciding which strings to use here, but are you okay with "Turn off display and sleep" being shortened to "Sleep"? That loses some detail, but I suspect that users expect the display to turn off when the system goes to sleep.

(On the slightly-brighter side, this setting is only disabled when it's been set by enterprise policy, so this issue mostly just affects Googlers rather than the general public.)
That string adjustment sounds OK to me, especially since it's for a case that's only visible by policy. Thanks for checking in!
Just to be clear, all three of these options are visible when policies are *not* set -- it was the other lid-closed setting that had the policy-only strings. "Turn off display and sleep" is actually the default behavior.

I think that the reason that policies are relevant here is because when the setting isn't disabled (because policy is not set), you can click on the menu to see the full strings. When policy disables the setting, there's no way to view the full strings.
Yep, I meant moreover that the policy makes it so users can't see the other settings (which help add color to what "sleep" means), but that wouldn't be the case for the average consumer user. Apologies for the poor wording in my previous comment :)
Status: Started (was: Assigned)
Thanks! Uploaded https://chromium-review.googlesource.com/c/chromium/src/+/653481 to change the string.
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e992cf53a7b53da01a3aeca6a4092dcd2adcecdf

commit e992cf53a7b53da01a3aeca6a4092dcd2adcecdf
Author: Daniel Erat <derat@chromium.org>
Date: Wed Sep 06 23:55:16 2017

chromeos: Use shorter string for power idle setting.

Change a power management setting option from "Turn off
display and sleep" (which is too long to fit in its
drop-down menu when translated to Japanese, and probably
also other languages) to "Sleep".

Bug:  761886 
Change-Id: If7451a1c2d4ec7fc8a13d208d9e2852ac99bc51d
Reviewed-on: https://chromium-review.googlesource.com/653481
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500143}
[modify] https://crrev.com/e992cf53a7b53da01a3aeca6a4092dcd2adcecdf/chrome/app/settings_strings.grdp

Labels: Merge-Request-62
Requesting a merge of this string change.
Labels: -Merge-Request-62 Merge-Rejected-62
Strings are frozen for 62. 
Status: Fixed (was: Started)
Got it; figured that might be the case.

Comment 17 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 18 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment