New issue
Advanced search Search tips

Issue 761848 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 495204



Sign in to add a comment

policy_templates.zip build edge fails in linux->win cross builds

Project Member Reported by thakis@chromium.org, Sep 4 2017

Issue description

[2/321] ACTION //components/policy:pack_policy_templates(//build/toolchain/win:win_clang_x86)
FAILED: policy_templates.zip 
python ../../components/policy/tools/make_policy_zip.py --output policy_templates.zip --basedir gen/chrome/app/policy --grd_input ../../components/policy/resources/policy_templates.grd --grd_strip_path_prefix app/policy --extra_input VERSION --grit_info ../../tools/grit/grit_info.py -D gen_policy_templates_common -D gen_policy_templates_win -D _chromium -E CHROMIUM_BUILD=chromium -D toolkit_views -D use_aura -t win32
Usage: make_policy_zip.py [options]

make_policy_zip.py: error: no such option: -t


https://chromium.googlesource.com/chromium/src/+/76942473295e92c2f34a6ed40a47a806dec38072%5E%21/#F4 looks kind of related, so does https://cs.chromium.org/chromium/src/components/policy/tools/grd_helper.py?q=get_grd_outputs&sq=package:chromium&dr=CSs&l=8 (called from https://cs.chromium.org/chromium/src/components/policy/tools/make_policy_zip.py?type=cs&q=make_policy_&sq=package:chromium&l=56)

This edge only exists on Windows, but it's not clear to me yet why it works in a win->win build.
 
Status: started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19f2ac379c003e6feb5cb13274bf1cf76b26bb99

commit 19f2ac379c003e6feb5cb13274bf1cf76b26bb99
Author: Nico Weber <thakis@chromium.org>
Date: Tue Sep 05 13:47:31 2017

Make policy_templates.zip work in linux->win cross builds.

Bug:  761848 
Change-Id: Ib352bb95ce9e1c9c1233208af0110bb427e06b9e
Reviewed-on: https://chromium-review.googlesource.com/650026
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499617}
[modify] https://crrev.com/19f2ac379c003e6feb5cb13274bf1cf76b26bb99/components/policy/tools/grd_helper.py

Status: Fixed (was: Started)

Sign in to add a comment