DCHECK failure trying to compute scrollbar pseudo style on ::before/::after pseudo
Reported by
r...@opera.com,
Sep 4 2017
|
||
Issue descriptionWe are trying to compute scrollbar pseudo style for overflow:scroll ::before/::after pseudo elements. Such computed style can never exist since ::before::-webkit-scrollbar is an invalid selector. This causes a DCHECK failure looking for ::slotted rule scopes in the presence of v1 shadow roots. This is similar to issue 760405.
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/202f9172e86515aeb72fa3db56c2bc82a0913333 commit 202f9172e86515aeb72fa3db56c2bc82a0913333 Author: Rune Lillesveen <rune@opera.com> Date: Tue Sep 05 05:20:06 2017 Don't compute pseudo element style on other pseudo elements. Nested pseudo elements are not allowed. We tried to match selectors for scrollbar pseudo elements on ::before/::after pseudo elements. This caused DCHECK failure in v1 shadow dom code trying to find assigned slot for the ::before/::after pseudo. Instead, return early trying to compute pseudo element style on pseudo elements. Bug: 761838 Change-Id: Iaa571c96701ad9f5eb87cb93f0cfb085f42c043e Reviewed-on: https://chromium-review.googlesource.com/649611 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#499564} [add] https://crrev.com/202f9172e86515aeb72fa3db56c2bc82a0913333/third_party/WebKit/LayoutTests/shadow-dom/crashes/scrollbar-pseudo.html [modify] https://crrev.com/202f9172e86515aeb72fa3db56c2bc82a0913333/third_party/WebKit/Source/core/layout/LayoutObject.cpp
,
Sep 5 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by dstockwell@google.com
, Sep 5 2017