New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761836 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Dragging down on page no longer reloads

Project Member Reported by wfh@chromium.org, Sep 4 2017

Issue description

Chrome Version: 63.0.3204.0
OS: Android 8.0.0; Pixel XL Build/OPR6.170623.011

What steps will reproduce the problem?
(1) load page
(2) drag the page down
(3)

What is the expected result?

Reload

What happens instead?

Nothing

Please use labels and text to provide additional information.

Works fine in Stable 60.0.3112.116
Works fine in Beta 61.0.3163.72
Works fine in Dev 62.0.3199.4

Variations on canary :

c641c173-f23d1dea
6a89113b-8842e68f
16e0dd70-3f4a17df
da89714-4ad60575
241fff6c-ec1be22a
c68ab9a3-3f4a17df
1e528f0f-15305a2
b130ecb8-2e32ee7e
6025934e-3f4a17df
d175604-65bced95
d5bf8633-3f4a17df
bd007046-3f4a17df
47e5d3db-3d47f4f4
e036a196-65bced95
77207729-e0e232cc
f0a371b8-65bced95
776de70c-e0278d3d
5ca89f9-f23d1dea
bf586af3-65bced95
19c1fdaf-3f4a17df
a82e9b43-3f4a17df
684d1cdf-51126808
287f29ba-323a85b
c561a755-3f4a17df
176d07dc-c518e03e
4429ef9e-8c0e6993
9773d3bd-7c7ea110
93731dca-3d47f4f4
81328e71-f23d1dea
9e5c75f1-fff58f2c
146193c5-f23d1dea
b2972962-e74d60f4
f79cb77b-3f4a17df
23a898eb-c40fe774
d1d8d202-db9e7dc4
4ea303a6-385dee18
12be2281-f23d1dea
d92562a9-ca7d8d80
f66ea88e-4eb6d224
1aecb842-3f4a17df
edcd3496-ca7d8d80
65a86f01-ca7d8d80
b2f0086-35ed162f
ef25c1eb-f23d1dea
344833e9-473e8c2e
4bc337ce-20dad077
db5efd10-88e62167
9a2f4e5b-ca7d8d80
494d8760-803f8fc4
3ac60855-3ec2a267
4442aae2-e1cc0f14
ed1d377-e1cc0f14
75f0f0a0-d7f6b13c
e7e71889-4ad60575
f5fff3a2-f23d1dea
11d91db8-3f4a17df
828a5926-c6c0a780
64fbb017-cf4f6ead

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Cc: msrchandra@chromium.org nyerramilli@chromium.org ligim...@chromium.org sandeepkumars@chromium.org
Components: UI>Browser
Labels: -Pri-2 ReleaseBlock-Beta M-62 Pri-1
Owner: perezju@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on Chrome# 63.0.3204.0 using Nexus 6P (Android 8.0.0). Also reproducible on Android 7.0 / 6.0 versions.
This is a regression issue in M62. Assigning to the owner manually as per revision bisect could not provide a possible suspect due to Crash builds being invoked.

Chrome Good Build -- 62.0.3200.6
Chrome Bad  Build -- 62.0.3202.3

CL --
https://chromium.googlesource.com/chromium/src/+log/62.0.3200.0..62.0.3202.0?pretty=fuller&n=10000

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/41df646478cc77acee7e2ee53730c51f992c69c9

@perezju -- Could you please look into the issue, kindly re-assign if it has nothing to do with your changes.
Adding RB label as this is a recent Regression. Please remove if not required.

Note: Please find the logs here --
go/chrome-androidlogs/761836
Thank You.
Owner: sunyunjia@chromium.org
My change is definitely not related; it only disables some test on the perf waterfall, cannot possibly affect Chrome builds.

Just scrolling through:
https://chromium.googlesource.com/chromium/src/+log/62.0.3200.0..62.0.3202.0?pretty=oneline&n=10000

The following stands out:

Use scroll-boundary-behavior to control overscroll-refresh/glow on android.
https://chromium.googlesource.com/chromium/src/+/bbea8a99d2643b97d9dfe9d368cba6d129850a28

sunyunjia could you have a look?
Status: Started (was: Assigned)
Cc: sunyunjia@chromium.org
 Issue 761818  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fbdd163f1fc94d035f8e738647dd0bd3e00a271

commit 3fbdd163f1fc94d035f8e738647dd0bd3e00a271
Author: Sandra Sun <sunyunjia@chromium.org>
Date: Tue Sep 05 15:01:47 2017

Consumed ScrollUpdate should not reset enabled OverscrollRefresh.

Consumed ScrollUpdate should reset OverscrollRefresh if it is awaiting
ScrollUpdateAck. However in commit 498816, it resets OverscrollRefresh
to DISABLED regardlessly. This patch fixes the regression.

Bug:  761836 
Change-Id: I66a9b69233aa34f330ca50bba080e8064b86505f
Reviewed-on: https://chromium-review.googlesource.com/649706
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499631}
[modify] https://crrev.com/3fbdd163f1fc94d035f8e738647dd0bd3e00a271/content/browser/android/overscroll_controller_android.cc
[modify] https://crrev.com/3fbdd163f1fc94d035f8e738647dd0bd3e00a271/content/browser/android/overscroll_controller_android_unittest.cc

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-62; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-62 label, otherwise remove Merge-TBD label. Thanks.
Labels: Merge-Request-62
Status: Verified (was: Fixed)
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 8 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 8 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d878074f1f16e95ad83c9ac3a9d635922e816af2

commit d878074f1f16e95ad83c9ac3a9d635922e816af2
Author: Sandra Sun <sunyunjia@chromium.org>
Date: Fri Sep 08 18:17:00 2017

Consumed ScrollUpdate should not reset enabled OverscrollRefresh.

Consumed ScrollUpdate should reset OverscrollRefresh if it is awaiting
ScrollUpdateAck. However in commit 498816, it resets OverscrollRefresh
to DISABLED regardlessly. This patch fixes the regression.

Bug:  761836 
Change-Id: I66a9b69233aa34f330ca50bba080e8064b86505f
Reviewed-on: https://chromium-review.googlesource.com/649706
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499631}(cherry picked from commit 3fbdd163f1fc94d035f8e738647dd0bd3e00a271)
Reviewed-on: https://chromium-review.googlesource.com/658177
Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#90}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/d878074f1f16e95ad83c9ac3a9d635922e816af2/content/browser/android/overscroll_controller_android.cc
[modify] https://crrev.com/d878074f1f16e95ad83c9ac3a9d635922e816af2/content/browser/android/overscroll_controller_android_unittest.cc

Cc: aelias@chromium.org
 Issue 763540  has been merged into this issue.
Labels: -Merge-TBD
 Issue 763877  has been merged into this issue.
Verified fix in 62.0.3202.19 and 63.0.3213.0. Thanks!

Sign in to add a comment