New issue
Advanced search Search tips
Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----



Sign in to add a comment
link

Issue 761829: Remove LogoTracker

Reported by sfiera@chromium.org, Sep 4 2017 Project Member

Issue description

LogoTracker is now an implementation detail of LogoService. In order to simplify things further, its implementation should move inside LogoService.
 

Comment 1 by mastiz@chromium.org, Sep 5 2017

Labels: -Pri-2 zine-triaged Pri-3
Adjusting priority since it's a cleanup task and is unassigned.

Comment 2 by sfiera@chromium.org, Sep 5 2017

Labels: -M-63 M-64

Comment 3 by fhorschig@chromium.org, Dec 14 2017

Labels: -M-64
Clean-up tasks don't need a target milestone.

Comment 4 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d3a5d132af98a9f373379208150a5eb5819d175

commit 0d3a5d132af98a9f373379208150a5eb5819d175
Author: Yeol <peary2@gmail.com>
Date: Fri Dec 07 10:00:43 2018

Merged LogoService and LogoTracker.

LogoTracker is now an implementation detail of LogoService.
In order to simplify things further,
its implementation was moved inside LogoService.

Bug: 761829
Change-Id: I33e5ab909e3f66aec31546bb1833069f973216c9
Reviewed-on: https://chromium-review.googlesource.com/c/1349511
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Yeol Park <peary2@gmail.com>
Cr-Commit-Position: refs/heads/master@{#614651}
[modify] https://crrev.com/0d3a5d132af98a9f373379208150a5eb5819d175/components/search_provider_logos/BUILD.gn
[modify] https://crrev.com/0d3a5d132af98a9f373379208150a5eb5819d175/components/search_provider_logos/fixed_logo_api.h
[modify] https://crrev.com/0d3a5d132af98a9f373379208150a5eb5819d175/components/search_provider_logos/logo_service_impl.cc
[modify] https://crrev.com/0d3a5d132af98a9f373379208150a5eb5819d175/components/search_provider_logos/logo_service_impl.h
[delete] https://crrev.com/3f353c8108d3c22e651c2deabc9a1597cbebcc5e/components/search_provider_logos/logo_tracker.cc
[modify] https://crrev.com/0d3a5d132af98a9f373379208150a5eb5819d175/components/search_provider_logos/logo_tracker.h
[modify] https://crrev.com/0d3a5d132af98a9f373379208150a5eb5819d175/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/0d3a5d132af98a9f373379208150a5eb5819d175/tools/traffic_annotation/summary/annotations.xml

Comment 5 by bugdroid1@chromium.org, Dec 14

Project Member

Sign in to add a comment