New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761828 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Remove LogoDelegate

Project Member Reported by sfiera@chromium.org, Sep 4 2017

Issue description

LogoDelegate was used as a mechanism for decoding untrusted logo images. Now, all platforms use the same LogoDelegateImpl, based on image_fetcher::ImageDecoder. LogoDelegateImpl should be removed, in favor of using an image_fetcher::ImageDecoder directly.
 
Labels: -Pri-2 zine-triaged Pri-3
Adjusting priority since it's a cleanup task and is unassigned.
Labels: -M-63 M-64
Labels: Type-Task
Labels: NTPDoodle
Owner: zhuoyu.q...@samsung.com
Status: Started (was: Available)
CL waiting review:
https://chromium-review.googlesource.com/c/chromium/src/+/1290583
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/977b9442453095dba17b4eac5fb7a43fbf023e26

commit 977b9442453095dba17b4eac5fb7a43fbf023e26
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Wed Oct 31 02:49:24 2018

Remove LogoDelegate

LogoDelegate was used as a mechanism for decoding untrusted logo images.
Now, all platforms use the same LogoDelegateImpl, based on
image_fetcher::ImageDecoder. LogoDelegateImpl should be removed,
in favor of using an image_fetcher::ImageDecoder directly.

Bug:  761828 
Change-Id: If5734629a0c16a0a8867421c783b6d49fad2545c
Reviewed-on: https://chromium-review.googlesource.com/c/1290583
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604121}
[modify] https://crrev.com/977b9442453095dba17b4eac5fb7a43fbf023e26/components/search_provider_logos/DEPS
[modify] https://crrev.com/977b9442453095dba17b4eac5fb7a43fbf023e26/components/search_provider_logos/logo_service_impl.cc
[modify] https://crrev.com/977b9442453095dba17b4eac5fb7a43fbf023e26/components/search_provider_logos/logo_tracker.cc
[modify] https://crrev.com/977b9442453095dba17b4eac5fb7a43fbf023e26/components/search_provider_logos/logo_tracker.h

Status: Fixed (was: Started)
I think it can close.

Sign in to add a comment