Remove LogoDelegate |
||||||
Issue descriptionLogoDelegate was used as a mechanism for decoding untrusted logo images. Now, all platforms use the same LogoDelegateImpl, based on image_fetcher::ImageDecoder. LogoDelegateImpl should be removed, in favor of using an image_fetcher::ImageDecoder directly.
,
Sep 5 2017
,
Sep 27 2017
,
Aug 15
,
Oct 24
CL waiting review: https://chromium-review.googlesource.com/c/chromium/src/+/1290583
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/977b9442453095dba17b4eac5fb7a43fbf023e26 commit 977b9442453095dba17b4eac5fb7a43fbf023e26 Author: Zhuoyu Qian <zhuoyu.qian@samsung.com> Date: Wed Oct 31 02:49:24 2018 Remove LogoDelegate LogoDelegate was used as a mechanism for decoding untrusted logo images. Now, all platforms use the same LogoDelegateImpl, based on image_fetcher::ImageDecoder. LogoDelegateImpl should be removed, in favor of using an image_fetcher::ImageDecoder directly. Bug: 761828 Change-Id: If5734629a0c16a0a8867421c783b6d49fad2545c Reviewed-on: https://chromium-review.googlesource.com/c/1290583 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#604121} [modify] https://crrev.com/977b9442453095dba17b4eac5fb7a43fbf023e26/components/search_provider_logos/DEPS [modify] https://crrev.com/977b9442453095dba17b4eac5fb7a43fbf023e26/components/search_provider_logos/logo_service_impl.cc [modify] https://crrev.com/977b9442453095dba17b4eac5fb7a43fbf023e26/components/search_provider_logos/logo_tracker.cc [modify] https://crrev.com/977b9442453095dba17b4eac5fb7a43fbf023e26/components/search_provider_logos/logo_tracker.h
,
Dec 7
I think it can close. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mastiz@chromium.org
, Sep 5 2017