New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 761816 link

Starred by 1 user
Status: Fixed
Owner:
█ enricobacis@google.com
Last visit > 30 days ago
Closed: Sep 2017
Cc:
machenb...@chromium.org
ahaas@chromium.org
clemensh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

tools/perf-to-html.py not working when result is 0

Project Member Reported by enricobacis@google.com, Sep 4 2017 
The tool perf-to-html.py, used to generate html pages from perf results, crashes in case one of the results happens to be 0 (the result is used to compute the percentage of improvement/regression).

It is possible to see a failed run here:

https://uberchromegw.corp.google.com/i/internal.client.v8/builders/v8_linux64_perf_try/builds/1310/steps/json%20to%20html/logs/stdio

When the divisor is 0, it's reasonable to output NaN.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b4a1f7920d0d2b9785c29e466e9b53f2d312c275

commit b4a1f7920d0d2b9785c29e466e9b53f2d312c275
Author: Enrico Bacis <enricobacis@google.com>
Date: Mon Sep 04 19:23:09 2017

[tool] prevent crash in tools/perf-to-html.py

The perf tests results are used by tools/perf-to-html.py to generate
html pages. Since the results are used as divisors to compute
percentages, when the one of them happens to be zero, the script
crashes.  This CL prevent the crash and uses the text "NaN" instead of
the percentage.

R=machenbach@chromium.org
CC=​ahaas@chromium.org,clemensh@chromium.org

Bug:  chromium:761816 
Change-Id: I482a85150c8323a7a837e6d589feee88279831cd
Reviewed-on: https://chromium-review.googlesource.com/649626
Commit-Queue: Enrico Bacis <enricobacis@google.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47806}
[modify] https://crrev.com/b4a1f7920d0d2b9785c29e466e9b53f2d312c275/tools/perf-to-html.py

Comment 2 by enricobacis@google.com, Sep 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment