New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 761798 link

Starred by 1 user
Status: Assigned
Owner:
█ alexclarke@chromium.org
Last visit > 30 days ago
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

inspector-protocol/emulation/device-emulation-desktop.js is failing on mac

Project Member Reported by alexclarke@chromium.org, Sep 4 2017 
We're getting RenderWidget::OnUpdateScreenRects called with a screen rect of 0,0,0,0. Might be related to https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_mac.mm?rcl=ae9aeec6fec838ca14977a01ef6e039b07ff53d3&l=1454
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a8cf486ed032a967e32fd6d76cd519183edc20f

commit 2a8cf486ed032a967e32fd6d76cd519183edc20f
Author: Alex Clarke <alexclarke@chromium.org>
Date: Tue Sep 05 01:21:48 2017

SetDeviceMetricsOverride to override screen size & position on desktop

Bug: 761798
Change-Id: Ic596f09085464550a9f484ac84bb8bd2743e7ece
Reviewed-on: https://chromium-review.googlesource.com/597747
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499532}
[modify] https://crrev.com/2a8cf486ed032a967e32fd6d76cd519183edc20f/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/2a8cf486ed032a967e32fd6d76cd519183edc20f/content/renderer/devtools/render_widget_screen_metrics_emulator.cc
[modify] https://crrev.com/2a8cf486ed032a967e32fd6d76cd519183edc20f/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/2a8cf486ed032a967e32fd6d76cd519183edc20f/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/2a8cf486ed032a967e32fd6d76cd519183edc20f/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-desktop-expected.txt
[add] https://crrev.com/2a8cf486ed032a967e32fd6d76cd519183edc20f/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-desktop.js
[modify] https://crrev.com/2a8cf486ed032a967e32fd6d76cd519183edc20f/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/2a8cf486ed032a967e32fd6d76cd519183edc20f/third_party/WebKit/public/web/DEPS
[modify] https://crrev.com/2a8cf486ed032a967e32fd6d76cd519183edc20f/third_party/WebKit/public/web/WebDeviceEmulationParams.h

Comment 2 by shrike@chromium.org, Sep 15 2017

Status: Assigned (was: Untriaged)
[mac bug triage] assigning to alexclarke@
►

Sign in to add a comment