https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/html/dialog/ appears to be a fairly good test suite for <dialog>, where many of the tests do not depend on internals or eventSender. These tests could be contributed to https://github.com/w3c/web-platform-tests/tree/master/html/semantics/interactive-elements/the-dialog-element to benefit other implementers.
foolip@, Many of those test cases under /html/dialog are using js-test.js. So first , do we need to convert it to testharness based and upstream ?
Yeah, they would need to be converted to use testharness.js.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b968a7f87c7e14fdfa6c64be42afd947c09a284b commit b968a7f87c7e14fdfa6c64be42afd947c09a284b Author: Shanmuga Pandi M <shanmuga.m@samsung.com> Date: Thu Sep 28 12:39:02 2017 Upstream LayoutTests/html/dialog/dialog-autofocus* to WPT. Convert the tests from js-test to testharness based tests and upstream the tests to WPT. Bug: 761790 Change-Id: I114f33f56bb79130574a84e6ba6d793991afcf06 Reviewed-on: https://chromium-review.googlesource.com/662886 Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#504980} [add] https://crrev.com/b968a7f87c7e14fdfa6c64be42afd947c09a284b/third_party/WebKit/LayoutTests/external/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-autofocus-multiple-times.html [add] https://crrev.com/b968a7f87c7e14fdfa6c64be42afd947c09a284b/third_party/WebKit/LayoutTests/external/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-autofocus.html [add] https://crrev.com/b968a7f87c7e14fdfa6c64be42afd947c09a284b/third_party/WebKit/LayoutTests/external/wpt/html/semantics/interactive-elements/the-dialog-element/resources/common.js [delete] https://crrev.com/0c2c8fcbde6fe3874ee970136ae198520472d897/third_party/WebKit/LayoutTests/html/dialog/dialog-autofocus-expected.txt [delete] https://crrev.com/0c2c8fcbde6fe3874ee970136ae198520472d897/third_party/WebKit/LayoutTests/html/dialog/dialog-autofocus-multiple-times-expected.txt [delete] https://crrev.com/0c2c8fcbde6fe3874ee970136ae198520472d897/third_party/WebKit/LayoutTests/html/dialog/dialog-autofocus-multiple-times.html [delete] https://crrev.com/0c2c8fcbde6fe3874ee970136ae198520472d897/third_party/WebKit/LayoutTests/html/dialog/dialog-autofocus.html
It's working :) https://wpt.fyi/html/semantics/interactive-elements/the-dialog-element/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bee55ab2d48b31f6f4aecbdb3b35966687c7b35d commit bee55ab2d48b31f6f4aecbdb3b35966687c7b35d Author: Shanmuga Pandi M <shanmuga.m@samsung.com> Date: Mon Oct 23 09:25:22 2017 Upstream LayoutTests/html/dialog/* to WPT. Bug: 761790 Change-Id: I2ff688a24eb5faba6bdd5e6cd941c27275601f9f Reviewed-on: https://chromium-review.googlesource.com/722403 Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#510745} [modify] https://crrev.com/bee55ab2d48b31f6f4aecbdb3b35966687c7b35d/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [add] https://crrev.com/bee55ab2d48b31f6f4aecbdb3b35966687c7b35d/third_party/WebKit/LayoutTests/external/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-enabled.html [add] https://crrev.com/bee55ab2d48b31f6f4aecbdb3b35966687c7b35d/third_party/WebKit/LayoutTests/external/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-return-value.html [add] https://crrev.com/bee55ab2d48b31f6f4aecbdb3b35966687c7b35d/third_party/WebKit/LayoutTests/external/wpt/html/semantics/interactive-elements/the-dialog-element/show-modal-focusing-steps.html [delete] https://crrev.com/c1d9de6a8a92efed7b8719802b12574695068230/third_party/WebKit/LayoutTests/html/dialog/dialog-enabled-expected.txt [delete] https://crrev.com/c1d9de6a8a92efed7b8719802b12574695068230/third_party/WebKit/LayoutTests/html/dialog/dialog-enabled.html [delete] https://crrev.com/c1d9de6a8a92efed7b8719802b12574695068230/third_party/WebKit/LayoutTests/html/dialog/dialog-return-value-expected.txt [delete] https://crrev.com/c1d9de6a8a92efed7b8719802b12574695068230/third_party/WebKit/LayoutTests/html/dialog/dialog-return-value.html [delete] https://crrev.com/c1d9de6a8a92efed7b8719802b12574695068230/third_party/WebKit/LayoutTests/html/dialog/show-modal-focusing-steps-expected.txt [delete] https://crrev.com/c1d9de6a8a92efed7b8719802b12574695068230/third_party/WebKit/LayoutTests/html/dialog/show-modal-focusing-steps.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45f1da33a24179624f748aa0b8df3f5c38fd1da1 commit 45f1da33a24179624f748aa0b8df3f5c38fd1da1 Author: Shanmuga Pandi M <shanmuga.m@samsung.com> Date: Thu Nov 23 13:14:08 2017 Upstream LayoutTests/html/dialog/*.html to WPT Convert js-test.js based tests to testHarness based on test. And upstream to WPT. Bug: 761790 Change-Id: I97b896cce51fa33a8a17c73fb0ed8242249881ff Reviewed-on: https://chromium-review.googlesource.com/768430 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#518911} [modify] https://crrev.com/45f1da33a24179624f748aa0b8df3f5c38fd1da1/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [add] https://crrev.com/45f1da33a24179624f748aa0b8df3f5c38fd1da1/third_party/WebKit/LayoutTests/external/wpt/html/semantics/interactive-elements/the-dialog-element/abspos-dialog-layout.html [add] https://crrev.com/45f1da33a24179624f748aa0b8df3f5c38fd1da1/third_party/WebKit/LayoutTests/external/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-scrolled-viewport.html [add] https://crrev.com/45f1da33a24179624f748aa0b8df3f5c38fd1da1/third_party/WebKit/LayoutTests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-does-not-match-disabled-selector.html [rename] https://crrev.com/45f1da33a24179624f748aa0b8df3f5c38fd1da1/third_party/WebKit/LayoutTests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-node-is-unfocusable.html [delete] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/third_party/WebKit/LayoutTests/html/dialog/abspos-dialog-layout-expected.txt [delete] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/third_party/WebKit/LayoutTests/html/dialog/abspos-dialog-layout.html [delete] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/third_party/WebKit/LayoutTests/html/dialog/dialog-scrolled-viewport-expected.txt [delete] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/third_party/WebKit/LayoutTests/html/dialog/dialog-scrolled-viewport.html [delete] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/third_party/WebKit/LayoutTests/html/dialog/inert-does-not-match-disabled-selector-expected.txt [delete] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/third_party/WebKit/LayoutTests/html/dialog/inert-does-not-match-disabled-selector.html [delete] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/third_party/WebKit/LayoutTests/html/dialog/inert-node-is-unfocusable-expected.txt
Comment 1 by foolip@chromium.org, Sep 4 2017