Renaming USB drive from Files App fails |
||||||||||
Issue description
Chrome Version : 63.0.3203.0
OS Version: 9907.0.0
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:
What steps will reproduce the problem?
1. Enable chrome://flags/#enable-external-drive-rename flag
2. Plug USB Drive
3. Open Files App, right click on USB Drive entry and select "Rename"
4. Enter "foo" and press "Enter"
What is the expected result?
USB Drive should be renamed to "foo"
What happens instead of that?
It is not.
Here are my system logs:
2017-09-04T13:06:31.187968+02:00 WARNING dosfslabel[7272]: libminijail[7272]: ioctl(SIOCSIFFLAGS) failed: Operation not permitted
2017-09-04T13:06:31.188004+02:00 ERR dosfslabel[7272]: libminijail[7272]: prctl(PR_SET_KEEPCAPS) failed: Operation not permitted
2017-09-04T13:06:31.212949+02:00 INFO crash_reporter[7287]: Falling back to parsing crash attributes '%P:6:213:dosfslabel' without UID
2017-09-04T13:06:31.212969+02:00 ERR crash_reporter[7287]: Invalid parameter: --user=%P:6:213:dosfslabel
2017-09-04T13:06:31.225082+02:00 ERR disks[1825]: Process 7272 for renaming '/sys/devices/pci0000:00/0000:00:14.0/usb1/1-1/1-1:1.0/host11/target11:0:0/11:0:0:0/block/sdb/sdb1' killed by a signal 6
,
Sep 5 2017
,
Sep 5 2017
Does this happen only on canary builds?
,
Sep 5 2017
I reproduced it on my local machine and prepared a patch.
,
Sep 11 2017
,
Sep 11 2017
,
Sep 11 2017
This seems P1, since renaming volumes does not work without the fix. Correct me if I'm wrong.
,
Sep 12 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/3fd136bb5e63831d8c8ad821dc1c2c376979d870 commit 3fd136bb5e63831d8c8ad821dc1c2c376979d870 Author: Klemen Kozjek <klemenko@google.com> Date: Fri Sep 08 04:21:29 2017 cros-disks: Do not overwrite capabilities of the rename process Because cros-disks runs as a non-privileged process with limited permissions, we are not able to change capabilities of a child process. Due to limited permissions, minijail will fail when it tries to prctl(PR_SET_KEEPCAPS). As a result of the CL, we do not overwrite capabilities of the rename process anymore. BUG= chromium:761775 TEST=platform_CrosDisksRename Change-Id: I1e2ae111b5fc437710ffd16c61c0a2aae722124d Reviewed-on: https://chromium-review.googlesource.com/649588 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Klemen Kozjek <klemenko@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/3fd136bb5e63831d8c8ad821dc1c2c376979d870/cros-disks/rename_manager.cc
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d3167626ae51b4fe5d0ca0eb10680ae3fe228f42 commit d3167626ae51b4fe5d0ca0eb10680ae3fe228f42 Author: Klemen Kozjek <klemenko@google.com> Date: Tue Sep 12 03:50:31 2017 cros-disks: Do not overwrite capabilities of the rename process Because cros-disks runs as a non-privileged process with limited permissions, we are not able to change capabilities of a child process. Due to limited permissions, minijail will fail when it tries to prctl(PR_SET_KEEPCAPS). As a result of the CL, we do not overwrite capabilities of the rename process anymore. BUG= chromium:761775 TEST=platform_CrosDisksRename Change-Id: I1e2ae111b5fc437710ffd16c61c0a2aae722124d Reviewed-on: https://chromium-review.googlesource.com/649588 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Klemen Kozjek <klemenko@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> (cherry picked from commit 3fd136bb5e63831d8c8ad821dc1c2c376979d870) Reviewed-on: https://chromium-review.googlesource.com/662260 Reviewed-by: Naoki Fukino <fukino@chromium.org> Tested-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> [modify] https://crrev.com/d3167626ae51b4fe5d0ca0eb10680ae3fe228f42/cros-disks/rename_manager.cc
,
Sep 15 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 19 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by klemenko@google.com
, Sep 5 2017