GridLayout doesn't handle properly lack of space |
|||
Issue descriptionChrome Version: 63.0.3204.0 OS: Linux In the manage passwords bubble we have a layout [FILL, FILL, TRAILING] with resize_percent [1, 1, 0]. But if we create a long username like 'superlongusernamesolonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglong' and normal password '12345' then the username is printed over the 'x' button as you can see in Issue 758157 . GridLayout calculated intersecting rects for different columns.
,
Oct 11 2017
,
Oct 12 2017
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eaeea6e5e051d6467a4f58e355c229d1094791a0 commit eaeea6e5e051d6467a4f58e355c229d1094791a0 Author: Scott Violet <sky@chromium.org> Date: Fri Oct 13 18:59:49 2017 Makes GridLayout honor minimum size When GridLayout is given less space than the preferred size it previously shrunk all columns marked as resizable, with no concern for the minimum. This patch makes GridLayout bound the shrinking by the minimum size. The minimum size is considered only for Views whose preferred width was not explicitly specified and the containing columns are resizable (resize_percent > 0) and don't have a fixed width. BUG=761767 TEST=covered by tests Change-Id: I00d501c27e2af229c8a161b6f6d3643f084fe055 Reviewed-on: https://chromium-review.googlesource.com/717498 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#508768} [modify] https://crrev.com/eaeea6e5e051d6467a4f58e355c229d1094791a0/ui/views/layout/grid_layout.cc [modify] https://crrev.com/eaeea6e5e051d6467a4f58e355c229d1094791a0/ui/views/layout/grid_layout.h [modify] https://crrev.com/eaeea6e5e051d6467a4f58e355c229d1094791a0/ui/views/layout/grid_layout_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by vasi...@chromium.org
, Sep 4 2017