CRAS:Default node gain is not applied on legacy node creation flow |
|||
Issue description
On Daisy, the mic jack node is created by jack:
"DAISY-I2S Mic Jack"
new_input get this jack name, but failed to associate the node of this jack with "Mic" section:
SectionDevice."Mic".0 {
Value {
JackName "DAISY-I2S Mic Jack"
CaptureControl "MIC2"
DefaultNodeGain "-700"
}
...
This is because we did not change node name.
We can fix this by changing the node name from "DAISY-I2S Mic Jack" to "Mic".
This is reasonable because in our legacy node creation flow we already identify its node type.
https://cs.corp.google.com/chromeos_public/src/third_party/adhd/cras/src/server/cras_alsa_io.c?type=cs&q=node-%3Etype+%3D+CRAS_NODE_TYPE_MIC+package:%5Echromeos_public$&l=945
,
Sep 5 2017
https://chromium-review.googlesource.com/650147 CRAS: alsa_io - Change name of the node created by jack posted.
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/d1442a3aea05ff11427ba73d76cd08f93918961a commit d1442a3aea05ff11427ba73d76cd08f93918961a Author: Cheng-Yi Chiang <cychiang@chromium.org> Date: Wed Sep 20 12:50:21 2017 CRAS: alsa_io - Change name of the node created by jack In legacy node creation flow, jack name will be used as node name. In this case the node fails to get the property set in UCM. For example, mic node on Daisy is named "Daisy-I2S Mic Jack". It can not get the properties set in "Mic" section in UCM. This CL fixes this by setting the node name to common name "Mic". Another solution is to change the section name in the UCM but it is better to use the common name as section name in the UCM. BUG= chromium:761765 ,chromium:747450 TEST=unittest TEST=check node name on peach_pit is common name. Change-Id: Idce617f51a711c457c20a88fc40b02e5bcbfc6d4 Reviewed-on: https://chromium-review.googlesource.com/650147 Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/d1442a3aea05ff11427ba73d76cd08f93918961a/cras/src/tests/alsa_io_unittest.cc [modify] https://crrev.com/d1442a3aea05ff11427ba73d76cd08f93918961a/cras/src/server/cras_alsa_io.c
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/32d90131bea0798df1aecb97ae338e9d224b71e3 commit 32d90131bea0798df1aecb97ae338e9d224b71e3 Author: Cheng-Yi Chiang <cychiang@chromium.org> Date: Tue Sep 26 08:03:11 2017 CRAS: alsa_io - Change name of the node created by jack In legacy node creation flow, jack name will be used as node name. In this case the node fails to get the property set in UCM. For example, mic node on Daisy is named "Daisy-I2S Mic Jack". It can not get the properties set in "Mic" section in UCM. This CL fixes this by setting the node name to common name "Mic". Another solution is to change the section name in the UCM but it is better to use the common name as section name in the UCM. BUG= chromium:761765 ,chromium:747450 TEST=unittest TEST=check node name on peach_pit is common name. Change-Id: Idce617f51a711c457c20a88fc40b02e5bcbfc6d4 Previous-Reviewed-on: https://chromium-review.googlesource.com/650147 (cherry picked from commit d2d23dd1479164c04f9168bc7ca76da03d5d86eb) Reviewed-on: https://chromium-review.googlesource.com/683916 Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/32d90131bea0798df1aecb97ae338e9d224b71e3/cras/src/tests/alsa_io_unittest.cc [modify] https://crrev.com/32d90131bea0798df1aecb97ae338e9d224b71e3/cras/src/server/cras_alsa_io.c
,
Sep 26 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by cychiang@chromium.org
, Sep 4 2017