New issue
Advanced search Search tips

Issue 761755 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug

Blocked on:
issue 778580
issue 779036

Blocking:
issue 809011
issue 845493



Sign in to add a comment

Support Incumbent realm in Blink

Project Member Reported by yukishiino@chromium.org, Sep 4 2017

Issue description

Blink is currently (a kind of) simulating Incumbent realm making cross origin accessible IDL operations always return a function created in the Current realm, which must be the Relevant realm in case of the same origin.

Implement Incumbent realm as HTML spec defines.

 
Labels: -OS-iOS
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/146841b1b3e8c7de3c0f3d7997277c5e7d9e1201

commit 146841b1b3e8c7de3c0f3d7997277c5e7d9e1201
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Tue Sep 05 03:34:08 2017

v8binding: Removes an unnecessary inheritance of V8AbstractEventListener.

DOMContentLoadedListener unnecessarily inherits from
V8AbstractEventListener.  It should inherit from EventListener as
it has nothing to do with v8::Function or such.

Bug: 761755
Change-Id: I6b4a327789fb6c0a3422cbb58e2d63c1580978fa
Reviewed-on: https://chromium-review.googlesource.com/647416
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499549}
[modify] https://crrev.com/146841b1b3e8c7de3c0f3d7997277c5e7d9e1201/third_party/WebKit/Source/core/xml/DocumentXSLT.cpp

Blockedon: 778580
Blockedon: 779036
Blocking: 809011
Blocking: 845493
Project Member

Comment 7 by bugdroid1@chromium.org, Yesterday (32 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78f80a999f0025f452e5b550098df47a130cf163

commit 78f80a999f0025f452e5b550098df47a130cf163
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Tue Jan 22 10:57:23 2019

v8binding: Use the incumbent realm instead of the current realm

Blink has been using the current realm as an approximation to
the incumbent realm, but after a long effort, now the incumbent
realm is almost ready for real use.

This patch starts using the incumbent realm for Window and
Document IDL interfaces.

Change-Id: I26b243ce1473ff3c282cad7078994bad2ca6f3ea
Bug: 761755
Reviewed-on: https://chromium-review.googlesource.com/c/1421418
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624756}
[modify] https://crrev.com/78f80a999f0025f452e5b550098df47a130cf163/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
[modify] https://crrev.com/78f80a999f0025f452e5b550098df47a130cf163/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h
[modify] https://crrev.com/78f80a999f0025f452e5b550098df47a130cf163/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/78f80a999f0025f452e5b550098df47a130cf163/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/78f80a999f0025f452e5b550098df47a130cf163/third_party/blink/renderer/core/dom/document.idl
[modify] https://crrev.com/78f80a999f0025f452e5b550098df47a130cf163/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/78f80a999f0025f452e5b550098df47a130cf163/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/78f80a999f0025f452e5b550098df47a130cf163/third_party/blink/renderer/core/frame/dom_window.cc
[modify] https://crrev.com/78f80a999f0025f452e5b550098df47a130cf163/third_party/blink/renderer/core/frame/dom_window.h
[modify] https://crrev.com/78f80a999f0025f452e5b550098df47a130cf163/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/78f80a999f0025f452e5b550098df47a130cf163/third_party/blink/renderer/core/frame/local_dom_window.h
[modify] https://crrev.com/78f80a999f0025f452e5b550098df47a130cf163/third_party/blink/renderer/core/frame/window.idl
[modify] https://crrev.com/78f80a999f0025f452e5b550098df47a130cf163/third_party/blink/renderer/modules/presentation/presentation_receiver.cc
[delete] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/third_party/blink/web_tests/external/wpt/dom/events/EventListener-incumbent-global-2.sub-expected.txt
[delete] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/third_party/blink/web_tests/http/tests/dom/EventListener-incumbent-global-2-expected.txt

Sign in to add a comment