New issue
Advanced search Search tips

Issue 761743 link

Starred by 1 user
Status: Fixed
Owner:
timloh@chromium.org
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Crash when tab navigates/closes under Android permission prompt following modal permission prompt

Project Member Reported by timloh@chromium.org, Sep 4 2017 
With modals enabled on Android:

1) Disable location permissions for Chrome
2) Run these:
 setTimeout(()=>{ window.location = "https://www.google.com"; }, 5000);
 navigator.geolocation.getCurrentPosition(()=>{});
3) Grant the website permission and wait for the navigation with the Android permission prompt active.

Chrome crashes after the navigation -- the modal tries to remove the actual UI surface, but it's already been removed.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c798a0bf186925f289bea2df0f556f1a92eeaa5f

commit c798a0bf186925f289bea2df0f556f1a92eeaa5f
Author: Timothy Loh <timloh@chromium.org>
Date: Mon Sep 04 08:24:10 2017

Fix crash when tab navigates/closes under Android permission prompt

Following a permission prompt, we prompt the user with an Android prompt
to give the browser permissions if it has not yet been granted. If modal
permission prompts are used, we currently crash if the tab navigates or
is closed while this Android prompt was active. This patch fixes this
crash.

Bug:  761743 

Change-Id: I4a2e378f57a3288e2e2f36d3db4455745e887d9b
Reviewed-on: https://chromium-review.googlesource.com/647954
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499457}
[modify] https://crrev.com/c798a0bf186925f289bea2df0f556f1a92eeaa5f/chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java

Comment 2 by timloh@chromium.org, Sep 4 2017

Status: Fixed (was: Started)
►

Sign in to add a comment