services_unittests failing on chromium.linux/Android Tests (dbg) |
|||||
Issue descriptionservices_unittests failing on chromium.linux/Android Tests (dbg) Builders failed on: - Android Tests (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29 Thread checker is firing in PlatformSensorProviderBase::CloneSharedBufferHandle on Android Tests (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45293 I 103.447s run_tests_on_device(06b8250f00622716) [ RUN ] GenericSensorServiceTest.MultipleClientsSuspendAndResumeTest I 103.447s run_tests_on_device(06b8250f00622716) [FATAL:platform_sensor_provider_base.cc(105)] Check failed: (thread_checker_).CalledOnValidThread(). I 10
,
Sep 4 2017
,
Sep 4 2017
,
Sep 4 2017
Looks like those failures were introduced from when new service tests were added in Change #81639 https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/43440 https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Tests__dbg_%2F43440%2F%2B%2Frecipes%2Fsteps%2Fservices_unittests_on_Android%2F0%2Fstdout ke.he@ Could you please take a look? Thanks.
,
Sep 4 2017
Removing from Sheriff queue since this is assigned and under way. Thanks.
,
Sep 5 2017
I'm trying to fix this by: https://chromium-review.googlesource.com/c/chromium/src/+/650208/2
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c1ec97a567fd8b253d575b840d88dbcdf85d143 commit 0c1ec97a567fd8b253d575b840d88dbcdf85d143 Author: Ke He <ke.he@intel.com> Date: Wed Sep 06 07:36:28 2017 Error fix for generic sensor service unittest. The FakePlatformSensorProvider that inherits PlatformSensorProviderBase is thread sensitive, there are many "thread_checkers" to assert it must be used in a same thread. In generic sensor service unittest, different test cases will create different IO-threads, so we have to create FakePlatformSensorProvider instances for each test cases instead of let them share the same one. BUG= 761742 Change-Id: Ib1a9d541b1d5abcee1b564e64589dd34fa449772 Reviewed-on: https://chromium-review.googlesource.com/650208 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com> Cr-Commit-Position: refs/heads/master@{#499896} [modify] https://crrev.com/0c1ec97a567fd8b253d575b840d88dbcdf85d143/services/device/generic_sensor/generic_sensor_service_unittest.cc
,
Sep 16 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 4 2017