New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 761718 link

Starred by 1 user
Status: Fixed
Owner:
x...@chromium.org
Closed: Nov 2017
Cc:
█ krajshree@chromium.org
ajha@chromium.org
█ brajkumar@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: ADD button is seen enabled by default in 'Add a nearby printer' page when no nearby printers are available.

Project Member Reported by jbanavatu@chromium.org, Sep 4 2017 
Chrome Version: 62.0.3202.7/9901.3.0 Blaze,Gnawty,Parrot
OS: Chrome OS

What steps will reproduce the problem?
(1) Sign in to chrome or Browse as guest >> Navigate to chrome://settings/cupsPrinters page
(2)Click on Add printer button >> Click on 'ADD NEARBY PRINTERS' link in Add a printer manually page
(3)Now observe ADD button in 'Add a nearby printer' page


Expected: ADD button should be disabled when no nearby printers are available.
Actual: Instead,ADD button is seen enabled by default.

This is regression issue as same is working fine in 61.0.3130.0/9671.0.0 dev channel blaze.

Attaching screen shot for reference.
Actual.png
676 KB View Download
Expected.png
40.7 KB View Download

Comment 1 by jbanavatu@chromium.org, Sep 4 2017

Description: Show this description

Comment 2 by steve...@chromium.org, Sep 5 2017

Cc: steve...@chromium.org
Labels: -Pri-1 Pri-2
Owner: x...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1c98a6da8b8b9e60f56f90f092feaf43bc4b6c3

commit d1c98a6da8b8b9e60f56f90f092feaf43bc4b6c3
Author: xdai <xdai@chromium.org>
Date: Thu Nov 09 20:34:31 2017

CUPS: ADD button should be disabled if there is no selected printer.

Bug:  761718 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If330d3684b0e01b5de32c271b30acac1e665d4b5
Reviewed-on: https://chromium-review.googlesource.com/756324
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515272}
[modify] https://crrev.com/d1c98a6da8b8b9e60f56f90f092feaf43bc4b6c3/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/d1c98a6da8b8b9e60f56f90f092feaf43bc4b6c3/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
[modify] https://crrev.com/d1c98a6da8b8b9e60f56f90f092feaf43bc4b6c3/chrome/test/data/webui/settings/cups_printer_page_tests.js

Comment 4 by x...@chromium.org, Nov 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment