autotest tko parser inserted multiple aborts for a given unexpected indent in the status.log file |
||
Issue description1) When there is a line with x amount of unexpected indents in the status.log file, version_1.py will insert x amount of abort line using subdir as the testname. When x >= 2, multiple abort will be reported for a given test since all aborts are using the same subdir. link: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/tko/parsers/version_1.py 2) parse.py has insufficient logging; parse.py logs test.subdir as testname and emits the actual testname field of an inserted test object. link: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/tko/parse.py
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/afe550a63024ebaf0dcb37870cd394998f748d71 commit afe550a63024ebaf0dcb37870cd394998f748d71 Author: Sida Liu <sidal@chromium.org> Date: Fri Oct 27 03:21:05 2017 [autotest] Bug fix: 1) modified parse.py to log test.testname and test.subdir 2) modified version_1.py to report abort for each unexpected indent using line.testname as testname. 3) modified version_1_unittest to add test for abort with no testname or no subdir BUG= chromium:761689 TEST=Ran unit tests for version_1.py; ran parse.py against several status.log with and without unexpected indents Change-Id: I03a3852df38ccfaabf216427398493f50619bbe3 Reviewed-on: https://chromium-review.googlesource.com/648643 Commit-Ready: Sida Liu <sidal@chromium.org> Tested-by: Sida Liu <sidal@chromium.org> Reviewed-by: Sida Liu <sidal@chromium.org> Reviewed-by: Michael Tang <ntang@chromium.org> [modify] https://crrev.com/afe550a63024ebaf0dcb37870cd394998f748d71/tko/parsers/version_1_unittest.py [modify] https://crrev.com/afe550a63024ebaf0dcb37870cd394998f748d71/tko/parse.py [modify] https://crrev.com/afe550a63024ebaf0dcb37870cd394998f748d71/tko/parsers/version_1.py
,
Jan 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1feaa04bd4090e284ad18fe266ba04e487b98391 commit 1feaa04bd4090e284ad18fe266ba04e487b98391 Author: Sida Liu <sidal@chromium.org> Date: Tue Jan 02 23:01:36 2018 [autotest] Bug fix: 1) modified parse.py to log test.testname and test.subdir 2) modified version_1.py to report abort for each unexpected indent using line.testname as testname. 3) modified version_1_unittest to add test for abort with no testname or no subdir BUG= chromium:761689 TEST=Ran unit tests for version_1.py; ran parse.py against several status.log with and without unexpected indents Change-Id: I03a3852df38ccfaabf216427398493f50619bbe3 Reviewed-on: https://chromium-review.googlesource.com/648643 Commit-Ready: Sida Liu <sidal@chromium.org> Tested-by: Sida Liu <sidal@chromium.org> Reviewed-by: Sida Liu <sidal@chromium.org> Reviewed-by: Michael Tang <ntang@chromium.org> (cherry picked from commit afe550a63024ebaf0dcb37870cd394998f748d71) Reviewed-on: https://chromium-review.googlesource.com/847958 Reviewed-by: Keith Haddow <haddowk@chromium.org> Commit-Queue: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/1feaa04bd4090e284ad18fe266ba04e487b98391/tko/parsers/version_1_unittest.py [modify] https://crrev.com/1feaa04bd4090e284ad18fe266ba04e487b98391/tko/parse.py [modify] https://crrev.com/1feaa04bd4090e284ad18fe266ba04e487b98391/tko/parsers/version_1.py |
||
►
Sign in to add a comment |
||
Comment 1 by sidal@chromium.org
, Sep 6 2017