New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761685 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Create dedicated WebContentsObserver to record URLs in UKM

Project Member Reported by bmcquade@chromium.org, Sep 3 2017

Issue description

Create dedicated WebContentsObserver to record URLs in UKM
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b59584bba3a92907f3183a7f80ffa9839cb4205d

commit b59584bba3a92907f3183a7f80ffa9839cb4205d
Author: Bryan McQuade <bmcquade@chromium.org>
Date: Wed Oct 04 13:22:59 2017

Add WebContentsObserver that records URLs in UKM.

This change migrates recording of URLs for
navigation-based source ids from page_load_metrics
to a more general dedicated WebContentsObserver.

The WebContentsObserver can be easily reused in both
unit tests and browser tests.

Bug:  761685 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I3f093dc7e4d2d32c438752371eec5df2e0c58c51
Reviewed-on: https://chromium-review.googlesource.com/648285
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506376}
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/chrome/browser/page_load_metrics/observers/local_network_requests_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/chrome/browser/page_load_metrics/page_load_tracker.h
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/chrome/test/BUILD.gn
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/components/BUILD.gn
[add] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/components/ukm/content/BUILD.gn
[add] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/components/ukm/content/DEPS
[add] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/components/ukm/content/source_url_recorder.cc
[add] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/components/ukm/content/source_url_recorder.h
[add] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/components/ukm/content/source_url_recorder_browsertest.cc
[add] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/components/ukm/content/source_url_recorder_test.cc
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/components/ukm/test_ukm_recorder.h
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/content/browser/frame_host/ancestor_throttle.cc
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/content/browser/frame_host/data_url_navigation_throttle.cc
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/content/browser/frame_host/navigation_handle_impl_browsertest.cc
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/content/public/browser/navigation_handle.h
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/content/public/test/navigation_handle_observer.cc
[modify] https://crrev.com/b59584bba3a92907f3183a7f80ffa9839cb4205d/content/public/test/navigation_handle_observer.h

Status: Fixed (was: Started)

Sign in to add a comment