New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 761665 link

Starred by 1 user
Status: Fixed
Owner:
█ reve...@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
█ elizabethchiu@chromium.org
zalcorn@chromium.org
steve...@chromium.org
nhendin@google.com
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Old default image discarded when signing in to device with new avatars.

Project Member Reported by reve...@chromium.org, Sep 3 2017 
Chrome Version: M61 and ToT
OS: ChromeOS

Steps to reproduce:

(1) Use a build with the old default image set.
(2) Select one of the default images as profile picture.
(3) Upgrade to ChromeOS build with new default image set.
(4) Remove user and go through the standard "add person" steps.

What is the expected result?

User image screen dialog should present the old default image as the current photo/file image option and only discarded if the user press the discard button or captures a new photo to replace it.

What happens instead?

Old default image has been discarded and is missing as an option in the user image screen dialog.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13

commit c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13
Author: David Reveman <reveman@chromium.org>
Date: Wed Sep 06 03:01:33 2017

login: Don't discard old default user image

This adds support for syncing of image index outside current set
and updates the user image screen to support old images.

Bug:  761665 
Test: old default user image is available on user image screen.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id3952955f6114420e122ac6171fedf5ca2dba910
Reviewed-on: https://chromium-review.googlesource.com/648807
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499862}
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/browser/chromeos/login/screens/user_image_screen.cc
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/browser/chromeos/login/users/default_user_image/default_user_images.h
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/browser/resources/chromeos/login/oobe_change_picture.html
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/browser/resources/chromeos/login/oobe_change_picture.js
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
[modify] https://crrev.com/c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13/chrome/test/data/chromeos/oobe_webui_browsertest.js

Comment 2 by reve...@chromium.org, Sep 6 2017

Labels: Merge-Request-61 Merge-Request-62
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 6 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by reve...@chromium.org, Sep 6 2017

Status: Fixed (was: Started)

Comment 5 by bhthompson@google.com, Sep 6 2017

Labels: -Merge-Request-62 Merge-Approved-62
Merge approved for 62, please ensure this CL makes it into ToT Chrome OS first, this does not appear to be in the last successful Chrome PFQ run, but it should be in by tomorrow.

Comment 6 by keta...@chromium.org, Sep 6 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 8 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3

commit 25b8b6aeba5bf46f5dc3f200e7c916f050a551c3
Author: David Reveman <reveman@chromium.org>
Date: Fri Sep 08 00:56:32 2017

login: Don't discard old default user image

This adds support for syncing of image index outside current set
and updates the user image screen to support old images.

TBR=reveman@chromium.org

(cherry picked from commit c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13)

Bug:  761665 
Test: old default user image is available on user image screen.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id3952955f6114420e122ac6171fedf5ca2dba910
Reviewed-on: https://chromium-review.googlesource.com/648807
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499862}
Reviewed-on: https://chromium-review.googlesource.com/656619
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1139}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/browser/chromeos/login/screens/user_image_screen.cc
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/browser/chromeos/login/users/default_user_image/default_user_images.h
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/browser/resources/chromeos/login/oobe_change_picture.html
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/browser/resources/chromeos/login/oobe_change_picture.js
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
[modify] https://crrev.com/25b8b6aeba5bf46f5dc3f200e7c916f050a551c3/chrome/test/data/chromeos/oobe_webui_browsertest.js
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 8 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ded9246b361290841d75f5c32b74c7ff9d1103b

commit 7ded9246b361290841d75f5c32b74c7ff9d1103b
Author: David Reveman <reveman@chromium.org>
Date: Fri Sep 08 00:57:52 2017

login: Don't discard old default user image

This adds support for syncing of image index outside current set
and updates the user image screen to support old images.

TBR=reveman@chromium.org

(cherry picked from commit c5d6a1ef85a97b8aaa2d5d52b0676fda9e683a13)

Bug:  761665 
Test: old default user image is available on user image screen.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id3952955f6114420e122ac6171fedf5ca2dba910
Reviewed-on: https://chromium-review.googlesource.com/648807
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499862}
Reviewed-on: https://chromium-review.googlesource.com/656677
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#77}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/browser/chromeos/login/screens/user_image_screen.cc
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/browser/chromeos/login/users/default_user_image/default_user_images.h
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/browser/resources/chromeos/login/oobe_change_picture.html
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/browser/resources/chromeos/login/oobe_change_picture.js
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
[modify] https://crrev.com/7ded9246b361290841d75f5c32b74c7ff9d1103b/chrome/test/data/chromeos/oobe_webui_browsertest.js
►

Sign in to add a comment