New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761655 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
cl



Sign in to add a comment

Null-dereference READ in blink::InspectorAnimationAgent::BuildObjectForAnimation

Project Member Reported by ClusterFuzz, Sep 3 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5920475523055616

Fuzzer: ochang_domfuzzer
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x000000a8
Crash State:
  blink::InspectorAnimationAgent::BuildObjectForAnimation
  blink::InspectorAnimationAgent::AnimationPlayStateChanged
  blink::probe::animationPlayStateChanged
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=471041:471079

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5920475523055616

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: msrchandra@chromium.org
Labels: cl M-61
Owner: suzyh@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "InspectorAnimationAgent.cpp" assigning to concern owner.

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/7ef6f8b862ad3fcc5f3e9634f77031d14d73862c

@suzyh -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Cc: ericwilligers@chromium.org
Components: Platform>DevTools
Owner: ----
Status: Untriaged (was: Assigned)
Suzy's change is after the regression interval.

The relevant animation in the crash is likely one of

{
    var effect = new KeyframeEffect(node, { opacity : [ 0.9 ] }, 1000);
    var anim = node.animate({});
    anim.effect = effect;
}

{
    var anim = nodeRO.animate(null);
    anim.effect = null;
}


I suspect InspectorAnimationAgent::BuildObjectForAnimation is crashing in the first few lines, and needs to allow for 
effect() being null, and/or the element being null.

(For an example of element null, see the layout test keyframeeffect-no-target-crash.html.)

Labels: CF-NeedsTriage
Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)
dgozman@ not sure if you're the right person for this but not sure who owns this part.
Project Member

Comment 5 by ClusterFuzz, Oct 1 2017

Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
Status: Fixed (was: Assigned)
Project Member

Comment 8 by ClusterFuzz, Oct 3 2017

ClusterFuzz has detected this issue as fixed in range 505750:505833.

Detailed report: https://clusterfuzz.com/testcase?key=5920475523055616

Fuzzer: ochang_domfuzzer
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x000000a8
Crash State:
  blink::InspectorAnimationAgent::BuildObjectForAnimation
  blink::InspectorAnimationAgent::AnimationPlayStateChanged
  blink::probe::animationPlayStateChanged
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=471041:471079
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=505750:505833

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5920475523055616

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Oct 3 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5920475523055616 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components

Sign in to add a comment