New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761641 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

OOBE profile picture UI sometimes shows up with non-zero scroll offset

Project Member Reported by reve...@chromium.org, Sep 2 2017

Issue description

This is a result of how we initially pick a random default user image and it might be one at the end of the list that requires scrolling to be visible.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/651b985e6cd88a85000d4543d77054c960e3c9e7

commit 651b985e6cd88a85000d4543d77054c960e3c9e7
Author: David Reveman <reveman@chromium.org>
Date: Tue Sep 05 17:43:02 2017

Change Picture: Limit random default image index

This limits random default image index to prevent undesirable UI
behavior when selecting an image with a high index. E.g. automatic
scrolling of picture list that is used to present default images.

always one of the first 14 images (origami avatars).

Bug:  761641 
Test: Add person and notice how the initial default image is
Change-Id: If317ed31a23b1157ad325460cb31957dee1c1b85
Reviewed-on: https://chromium-review.googlesource.com/648732
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499668}
[modify] https://crrev.com/651b985e6cd88a85000d4543d77054c960e3c9e7/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc

Labels: Merge-Request-61 Merge-Request-62
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 6 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
Labels: -Merge-Request-62 Merge-Approved-62
Merge approved for 62, please ensure this CL makes it into ToT Chrome OS first, this does not appear to be in the last successful Chrome PFQ run, but it should be in by tomorrow (63.0.3207.0+ should pass PFQ first).
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 8 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25ce179cbda544c931f1e8e4008617ca7b4be9a9

commit 25ce179cbda544c931f1e8e4008617ca7b4be9a9
Author: David Reveman <reveman@chromium.org>
Date: Fri Sep 08 00:59:51 2017

Change Picture: Limit random default image index

This limits random default image index to prevent undesirable UI
behavior when selecting an image with a high index. E.g. automatic
scrolling of picture list that is used to present default images.

always one of the first 14 images (origami avatars).

TBR=reveman@chromium.org

(cherry picked from commit 651b985e6cd88a85000d4543d77054c960e3c9e7)

Bug:  761641 
Test: Add person and notice how the initial default image is
Change-Id: If317ed31a23b1157ad325460cb31957dee1c1b85
Reviewed-on: https://chromium-review.googlesource.com/648732
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499668}
Reviewed-on: https://chromium-review.googlesource.com/656697
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#78}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/25ce179cbda544c931f1e8e4008617ca7b4be9a9/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 8 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a20421d915faac9cff5c6c633003b260a1e33ec9

commit a20421d915faac9cff5c6c633003b260a1e33ec9
Author: David Reveman <reveman@chromium.org>
Date: Fri Sep 08 01:01:53 2017

Change Picture: Limit random default image index

This limits random default image index to prevent undesirable UI
behavior when selecting an image with a high index. E.g. automatic
scrolling of picture list that is used to present default images.

always one of the first 14 images (origami avatars).

TBR=reveman@chromium.org

(cherry picked from commit 651b985e6cd88a85000d4543d77054c960e3c9e7)

Bug:  761641 
Test: Add person and notice how the initial default image is
Change-Id: If317ed31a23b1157ad325460cb31957dee1c1b85
Reviewed-on: https://chromium-review.googlesource.com/648732
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499668}
Reviewed-on: https://chromium-review.googlesource.com/656698
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1141}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/a20421d915faac9cff5c6c633003b260a1e33ec9/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc

Sign in to add a comment