Issue metadata
Sign in to add a comment
|
Regression: Scrolling on NewTabPage and Google homepage is not smooth, when the mouse cursor is over the Google Search Bar |
||||||||||||||||||||||
Issue descriptionChrome Version: 63.0.3203.0 Canary OS: macOS 10.12.6 Device: MacBook Air 11" Mid 2012 What steps will reproduce the problem? (1) Open a NewTabPage. (2) Shrink the window, so that you have a vertical scrollbar. (3) Move the mouse cursor over the Google Search Bar, but *don't* click into it. You will notice that the Google Search bar borders will be highlighted with a shadow. (4) Now scroll with the Trackpad up and down What is the expected result? A smooth scrolling behaviour. What happens instead? Scrolling is not smooth. It is choppy. If you need more information, please let me know. This works fine in Chrome Stable 60.0.3112.113.
,
Sep 3 2017
It seems, that I am on an Experiment. I disabled all scrolling related flags one after one. Disabling chrome://flags/#disable-threaded-scrolling fixes the issue. If you need more information, please let me know.
,
Sep 3 2017
A bisect probably can't help here, because I am probably on an Experiment :-( (I tried it in latest Chromium Snapshots, but I can not reproduce it there.) As mentioned in c#2, in Canary disabling chrome://flags/#disable-threaded-scrolling fixes the problem. Thank you in advance.
,
Sep 4 2017
I can reproduce this on Mac only; Windows and Linux seem fine. The disable-threaded-scrolling flag is ancient (introduced in 2014), and as far as I can tell we don't have any active experiments with it. So I don't think that's the cause. We did do some CSS changes on the NTP in Chrome 61 which might be related, see bug 734038. In particular, we added a :hover style on the fakebox (which adds a box-shadow). I don't see why that would impact scrolling though. Also interesting: The local NTP (chrome-search://local-ntp/local-ntp.html) has the exact same :hover effect, but it doesn't show the choppy scrolling.
,
Sep 4 2017
treib@ Thanks for your feedback. Just an additional note: I can also reproduce it at https://www.google.de/ with latest Canary.
,
Sep 4 2017
Indeed, I can reproduce it on google.com too. That means it's probably triggered by some server-side piece that's common between the Google homepage and the remote NTP. (Though ultimately, it's still a bug in Chrome of course.) Given that per #4 it's likely *not* due to an experiment, could we get a bisect?
,
Sep 4 2017
Adding some Blink folks, since Blink>Scroll doesn't have dedicated owners. Can you help route/triage this? Thanks!
,
Sep 5 2017
Able to reproduce the issue on mac os 10.12.6 using chrome M63 #63.0.3205.0 . This is a regression issue broken in M62 and seen only in mac os (Non-Retina). Using the per-revision bisect providing the bisect results, Good build: 62.0.3197.0 (Revision: 497604). Bad build: 62.0.3198.0 (Revision: 497674). You are probably looking for a change made after 497615 (known good), but no later than 497616 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/9b8fb34db903643b759635086dcf0da90b1e3082..668749693c0abc7f00871a2abea73628e6aa0332 From the CL above, assigning the issue to the concern owner @Steve Kobes - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Reviewed-on: https://chromium-review.googlesource.com/634512 Thanks!
,
Sep 5 2017
,
Sep 5 2017
+ReleaseBlock, since this is a regression.
,
Sep 5 2017
My change is definitely not related (it only affects test code). I can repro on Mac Canary. I think it's related to the transition animation that removes the drop shadow highlight from the search box on mouseout. On stable (where the bug doesn't repro), the search box has a much more subtle highlight without a transition animation. Routing to estade from ntp/OWNERS to verify. (Note, if this is indeed caused by a change to NTP styling, it may be worth filing a separate bug for Blink to handle the animation better.)
,
Sep 5 2017
I haven't worked on NTP for many years. Hopefully the components labels will bring this to the correct person's attention, for now I'll pass off to tkent@ because it's probably worth addressing at the Blink level.
,
Sep 5 2017
"Dispatch mouse transition events after layout" might affect this issue.
,
Sep 6 2017
Re #11: I have verified that Chrome 61 (which already has the new CSS), is not affected, so this is not caused by the new CSS alone.
,
Sep 6 2017
Attached is a trace of the issue. I wonder if we have a scheduling issue here. The trace shows the NTP is backgrounded but it isn't (is that actually correct?) and the main frame is actually delayed yet the CPU is actually idle. altimin@ can you take a look?
,
Sep 6 2017
Sami and I have looked into that and it seems that tree activation takes 300ms to activate and it's not obvious why. Main thread is blocked by ProxyMain::BeginMainFrame::commit waiting for something, but compositor thread and tile workers don't seem busy. So I don't think that it is a scheduling issue and let's have compositor folks to look into that.
,
Sep 6 2017
ccameron@ can you look at this from a compositing point of view?
,
Sep 7 2017
I can't reproduce it any longer in today's Canary 63.0.3208.0. Is this also fixed for you all?
,
Sep 7 2017
I can't seem to repro it. Change log is here: https://chromium.googlesource.com/chromium/src/+log/63.0.3207.0..63.0.3208.0?pretty=fuller&n=10000 because I did repro it on 63.0.3207.0 flackr@ could https://chromium-review.googlesource.com/c/chromium/src/+/591913 be the fix?
,
Sep 12 2017
Closing as not reproducible anymore. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Sep 3 2017