New issue
Advanced search Search tips

Issue 761617 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in blink::BaseAudioContext::IsDestinationInitialized

Project Member Reported by ClusterFuzz, Sep 2 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4542173273128960

Fuzzer: inferno_twister_c
Job Type: windows_syzyasan_chrome
Platform Id: windows

Crash Type: Heap-use-after-free READ 1
Crash Address: 0x2c2c2c38
Crash State:
  blink::BaseAudioContext::IsDestinationInitialized
  blink::BaseAudioContext::~BaseAudioContext
  blink::FinalizerTraitImpl<blink::ServiceWorkerClient,1>::Finalize
  
Memory Tool: SYZYASAN

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_chrome&range=498677:498753

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4542173273128960

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 2 2017

Labels: M-62
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 2 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 2 2017

Labels: Pri-1
Cc: kinuko@chromium.org haraken@chromium.org hongchan@chromium.org
I'm not sure what's going on here. Nothing obvious in the blame range.

+ a few Blink people on SW, Oilpan, and WebAudio. Please retriage if you could, thanks!
Cc: rtoy@chromium.org

Comment 6 by rtoy@chromium.org, Sep 5 2017

Components: Blink>WebAudio
Project Member

Comment 7 by ClusterFuzz, Sep 6 2017

ClusterFuzz has detected this issue as fixed in range 499699:499749.

Detailed report: https://clusterfuzz.com/testcase?key=4542173273128960

Fuzzer: inferno_twister_c
Job Type: windows_syzyasan_chrome
Platform Id: windows

Crash Type: Heap-use-after-free READ 1
Crash Address: 0x2c2c2c38
Crash State:
  blink::BaseAudioContext::IsDestinationInitialized
  blink::BaseAudioContext::~BaseAudioContext
  blink::FinalizerTraitImpl<blink::ServiceWorkerClient,1>::Finalize
  
Memory Tool: SYZYASAN

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_chrome&range=498677:498753
Fixed: https://clusterfuzz.com/revisions?job=windows_syzyasan_chrome&range=499699:499749

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4542173273128960

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Sep 6 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase 4542173273128960 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 6 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify

Comment 10 by rtoy@chromium.org, Sep 6 2017

hongchan@: Do you think this is really fixed? The fixed range doesn't have any webaudio changes.  There are a couple v8 autorolls, though.
Perhaps - I believe this crash was not really originated from WebAudio. We didn't change the code above for a long time. Two possibilities:

1. Something might have changes in GC. (The crash happens when GC kicks in)
2. The issue is super hard to reproduce, so CF gave up and marked it as fixed/verified.

@haraken WDYT?
Owner: keishi@chromium.org
Yes, I think this is a bug of Oilpan GC.

> Crash Address: 0x2c2c2c38

^^^ This means that we're touching an already freed object.

keishi@: Would you mind taking a look at this?

Labels: -ReleaseBlock-Stable -M-62 M-66
Project Member

Comment 14 by sheriffbot@chromium.org, Dec 13 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment