New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761589 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Icon in Settings menu doesn't update properly

Project Member Reported by lesliewatkins@chromium.org, Sep 2 2017

Issue description

OS: CrOS

What steps will reproduce the problem?
(1) Open Network Settings, the Mobile Data.
(2) Click on a Tether network to connect to.

What is the expected result?
The icon immediately begins the throbbing animation and the subtitle 'Connecting...' appears under the network name.

What happens instead?
The icon and subtitle don't update immediately.

It seems like the update might be triggered by showing the icon elsewhere (e.g. Opening network quick settings in the System Tray).
 
Cc: steve...@chromium.org
Components: UI>Shell>Networking>Tethering
The updates are triggered at [1]. In this case, it's the NetworkConnectionStateChanged() observer function. It looks like they throttle updates to the list to a maximum of once every kUpdateFrequencyMs milliseconds, where kUpdateFrequencyMs = 1000. Leslie, were you seeing updates that were delayed up to 1 second?

Looks like this change was made by stevenjb@ in [2]. Steven, can you shed some light on why this is necessary?

[1] https://cs.chromium.org/chromium/src/ash/system/network/tray_network_state_observer.cc
[2] https://codereview.chromium.org/811623002
UI updates are expensive. Sometimes updates can be noisy so the 1s delay "debounces" that. I am surprised it is noticeable, but we could probably make the logic smarter, e.g. reset the debounce timer after a user action like 'connect'.
Labels: -M-61 M-63
Yep, that's a good idea. I think we should land a fix which always refreshes the list immediately if the user clicks on the UI.

However, I do not consider this a launch-blocking issue. Moving to M-63.
Labels: -M-63 M-64

Comment 5 Deleted

Labels: -Pri-2 -M-64 Pri-3
Status: Available (was: Untriaged)
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 10

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Enterprise-Triaged

Sign in to add a comment