New issue
Advanced search Search tips

Issue 761573 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

External data use observer field trial should be added to list of field trials for testing

Project Member Reported by tbansal@chromium.org, Sep 2 2017

Issue description

Field trial "ExternalDataUseObserver" should be added to 
testing/variations/fieldtrial_testing_config.json so that it is enabled by default in all debug/test Android builds. That would help us in catching any regressions related to the field trial.
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfeea62baf5d453735e86895e1f93ce28a920579

commit cfeea62baf5d453735e86895e1f93ce28a920579
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Sep 06 01:27:55 2017

Add thread checking to external data use observer

Also, add the field trial to the list of field trials.

Bug:  761573 
Change-Id: I104c92453996065e143117dbc73b9586cfb9bff8
Reviewed-on: https://chromium-review.googlesource.com/644071
Reviewed-by: rajendrant <rajendrant@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499835}
[modify] https://crrev.com/cfeea62baf5d453735e86895e1f93ce28a920579/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java
[modify] https://crrev.com/cfeea62baf5d453735e86895e1f93ce28a920579/testing/variations/fieldtrial_testing_config.json

Comment 3 by bengr@chromium.org, Sep 15 2017

Owner: rajendrant@google.com
Status: Assigned (was: Untriaged)
Cc: rajendrant@chromium.org
Owner: tbansal@chromium.org
Status: Fixed (was: Assigned)
Sorry, this is already fixed. I wanted to do it asap because I was fixing  some P1 bug related to data use observer.

Sign in to add a comment