New issue
Advanced search Search tips

Issue 761564 link

Starred by 2 users
Status: Fixed
Owner:
khushals...@chromium.org
Closed: Jun 2018
Cc:
vmp...@chromium.org
khushals...@chromium.org
chrishtr@chromium.org
ericrk@chromium.org
cblume@chromium.org
enne@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocked on:
issue 558070


Sign in to add a comment

Decode to scale: check if a larger version already exists before decoding

Project Member Reported by vmp...@chromium.org, Sep 1 2017 
With decode to scale, if we can use the exact image size then we'll decode to that. However, we should first check if a larger decode is already available and instead scale that. The reason it's not a problem right now is because we always go to original and scale, but with decode to scale that changes.

Comment 1 by vmp...@chromium.org, Sep 1 2017

Blockedon: 558070
Labels: -Type-Bug Type-Task

Comment 2 by vmp...@chromium.org, Jan 26 2018

Cc: vmp...@chromium.org
Owner: khushals...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a96307a3111a8a8c15a3303be7732b2508c8ced5

commit a96307a3111a8a8c15a3303be7732b2508c8ced5
Author: Khushal <khushalsagar@chromium.org>
Date: Thu Jun 21 18:01:46 2018

cc: Use decode to scale in software image cache.

Use the PaintImage::GetSupportedDecodeSize API in the
SoftwareImageDecodeCache to decode directly to the scaled size, instead
of decoding to the original size and scaling.

R=ericrk@chromium.org

Bug:  558070 , 761564 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia2e71961acad9f40648212f8be5fef734fea9fe3
Reviewed-on: https://chromium-review.googlesource.com/1106608
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569321}
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/cc/test/fake_paint_image_generator.cc
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/cc/test/fake_paint_image_generator.h
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/cc/tiles/software_image_decode_cache.cc
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/cc/tiles/software_image_decode_cache.h
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/cc/tiles/software_image_decode_cache_unittest.cc
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/cc/tiles/software_image_decode_cache_utils.cc
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/color-profile-animate-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/color-profile-animate-rotate-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/color-profile-background-image-cover-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/color-profile-background-image-repeat-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/color-profile-border-fade-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/color-profile-image-canvas-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/color-profile-image-object-fit-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/color-profile-image-svg-resource-url-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/color-profile-layer-filter-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/color-profile-mask-image-svg-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/jpeg-yuv-progressive-canvas-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/images/jpeg-yuv-progressive-image-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/media/color-profile-video-poster-image-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/fast/replaced/image-sizing-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-image-shape-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/images/jpeg-with-color-profile-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/svg/custom/image-rescale-clip-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/svg/custom/image-rescale-scroll-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug4284-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug625-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/bloomberg-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-image-shape-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/jpeg-with-color-profile-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac-mac10.11/tables/mozilla/core/bloomberg-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/fast/replaced/image-sizing-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-border-radius-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-filter-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-image-canvas-svg-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-image-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-image-shape-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/images/jpeg-with-color-profile-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/svg/custom/image-rescale-clip-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/svg/custom/image-rescale-scroll-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug4284-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug625-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/core/bloomberg-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-border-radius-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-filter-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-image-canvas-svg-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-image-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-image-shape-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-layer-filter-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/jpeg-with-color-profile-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/fast/replaced/image-sizing-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/images/color-profile-border-radius-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/images/color-profile-filter-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/images/color-profile-image-canvas-svg-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/images/color-profile-image-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/images/color-profile-image-shape-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/images/jpeg-with-color-profile-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/svg/custom/image-rescale-clip-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/svg/custom/image-rescale-scroll-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug4284-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/core/bloomberg-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-border-radius-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-filter-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-image-canvas-svg-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-image-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-image-shape-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-layer-filter-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/jpeg-with-color-profile-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-animate-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-animate-rotate-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-background-image-cover-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-background-image-repeat-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-image-canvas-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-image-object-fit-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-image-svg-resource-url-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-mask-image-svg-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/jpeg-yuv-progressive-canvas-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/jpeg-yuv-progressive-image-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/a96307a3111a8a8c15a3303be7732b2508c8ced5/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/jpeg-yuv-progressive-canvas-expected.png

Comment 4 by khushals...@chromium.org, Jun 21 2018

Status: Fixed (was: Assigned)
The change above ensures that we prefer scaling from a cached decode.
►

Sign in to add a comment