Revert all changes for download foreground service refactor for M62 |
||||||
Issue descriptionRevert all changes for download foreground service refactor for M62 We will turn them back on in M63.
,
Sep 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d91c99051aba2b8debe80be757598027d5d159c0 commit d91c99051aba2b8debe80be757598027d5d159c0 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Sat Sep 02 01:00:58 2017 Revert "Download Home : Using startService to perform user-initiated action" This reverts commit 2054f23825cab99f1b17ed0f3ca889ea3ac03b1d. Bug: 761562 Change-Id: Idf037b5fbc1b9f61935c3f91a2472a68b78d7028 Reviewed-on: https://chromium-review.googlesource.com/648229 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#499364} [modify] https://crrev.com/d91c99051aba2b8debe80be757598027d5d159c0/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
,
Sep 2 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 5 2017
Hi Alex, This CL is part of the rollbacks in order to make downloads work correctly in M-62. We will go ahead with our downloads foreground service refactor work in M-63. But for M-62, we decided to rollback everything to the previous state before branch point to be on safe side.
,
Sep 5 2017
,
Sep 5 2017
Approved for M62 branch 3202.
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6093ad3bbb0a32945c01054d061e263ec3513ca2 commit 6093ad3bbb0a32945c01054d061e263ec3513ca2 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Tue Sep 05 22:08:43 2017 Revert "Download Home : Using startService to perform user-initiated action" This reverts commit 2054f23825cab99f1b17ed0f3ca889ea3ac03b1d. TBR=shaktisahu@chromium.org (cherry picked from commit d91c99051aba2b8debe80be757598027d5d159c0) Bug: 761562 Change-Id: Idf037b5fbc1b9f61935c3f91a2472a68b78d7028 Reviewed-on: https://chromium-review.googlesource.com/648229 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499364} Reviewed-on: https://chromium-review.googlesource.com/651229 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#34} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/6093ad3bbb0a32945c01054d061e263ec3513ca2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by shaktisahu@chromium.org
, Sep 2 2017