Issue 761556 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	sammiequon@chromium.org
Closed:	Sep 2017
Cc:	mustash-bugs@google.com
Components:	Internals>Services>WindowService
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug

Blocking:
issue 578868

move PeripheralBatteryNotifier into ash/

Project Member Reported by est...@chromium.org, Sep 1 2017

Issue description

It seems this class can/should live in ash/. This would solve the problem of it calling directly into ash/ (which it can't do in mash) as well as calling directly into the message center (which won't be in the browser process in mash).

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95c6a1c9128835ebd44c8aa778727229ff858175

commit 95c6a1c9128835ebd44c8aa778727229ff858175
Author: Sammie Quon <sammiequon@google.com>
Date: Tue Sep 12 19:16:55 2017

ash: Move peripheral battery notifier to ash/.

Test: ash_unittests PeripheralBatteryNotifierTest.*
Bug:  761556 
Change-Id: I45f691d17380812c37de13d5d3a8df9d87ad2fa6
Reviewed-on: https://chromium-review.googlesource.com/656513
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501354}
[modify] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/ash/BUILD.gn
[modify] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/ash/DEPS
[modify] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/ash/resources/ash_resources.grd
[rename] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/ash/resources/default_100_percent/cros/notification/notification_peripheral_battery_low.png
[rename] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/ash/resources/default_200_percent/cros/notification/notification_peripheral_battery_low.png
[modify] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/ash/shell.cc
[modify] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/ash/shell.h
[rename] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/ash/system/power/peripheral_battery_notifier.cc
[rename] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/ash/system/power/peripheral_battery_notifier.h
[rename] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/ash/system/power/peripheral_battery_notifier_unittest.cc
[modify] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/95c6a1c9128835ebd44c8aa778727229ff858175/chrome/browser/chromeos/chrome_browser_main_chromeos.h