New issue
Advanced search Search tips

Issue 761527 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[Media Router WebUI] Seek bar not updated when tab not shown

Project Member Reported by taku...@chromium.org, Sep 1 2017

Issue description

This is a regression in the new WebUI route controller.

When you have a dialog showing the route details view in a tab, switch to another tab for some time and come back, the seek bar hasn't progressed while the dialog wasn't shown. So the time shown would be incorrect until another route status update is received.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8736bdf82af074f246c448c9483d3fd2cb33131f

commit 8736bdf82af074f246c448c9483d3fd2cb33131f
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Thu Sep 07 17:34:04 2017

[Media Router WebUI] Increment seek bar position based on time passed

Instead of incrementing the time by 1 second each time the timeout callback is called, we update the time based on how much time has passed since the last route status update.
This fixes the bug in which the time doesn't get incremented when we're on another tab.

Bug:  761527 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I42a0a0ff4feaadafdfa04662a173829949ac6ca5
Reviewed-on: https://chromium-review.googlesource.com/647408
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500326}
[modify] https://crrev.com/8736bdf82af074f246c448c9483d3fd2cb33131f/chrome/browser/resources/media_router/elements/route_controls/route_controls.js
[modify] https://crrev.com/8736bdf82af074f246c448c9483d3fd2cb33131f/chrome/test/data/webui/media_router/route_controls_tests.js

Labels: Merge-Request-62
I'd like to request a merge of the above CL to M62.
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 8 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65e57c2788a72f13e1855a3074f5ab6416aad8fb

commit 65e57c2788a72f13e1855a3074f5ab6416aad8fb
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Fri Sep 08 18:42:01 2017

[Media Router WebUI] Increment seek bar position based on time passed

Instead of incrementing the time by 1 second each time the timeout callback is called, we update the time based on how much time has passed since the last route status update.
This fixes the bug in which the time doesn't get incremented when we're on another tab.

TBR=takumif@chromium.org

(cherry picked from commit 8736bdf82af074f246c448c9483d3fd2cb33131f)

Bug:  761527 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I42a0a0ff4feaadafdfa04662a173829949ac6ca5
Reviewed-on: https://chromium-review.googlesource.com/647408
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500326}
Reviewed-on: https://chromium-review.googlesource.com/657461
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#91}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/65e57c2788a72f13e1855a3074f5ab6416aad8fb/chrome/browser/resources/media_router/elements/route_controls/route_controls.js
[modify] https://crrev.com/65e57c2788a72f13e1855a3074f5ab6416aad8fb/chrome/test/data/webui/media_router/route_controls_tests.js

Status: Fixed (was: Started)

Sign in to add a comment