[Media Router WebUI] Seek bar not updated when tab not shown |
|||||
Issue descriptionThis is a regression in the new WebUI route controller. When you have a dialog showing the route details view in a tab, switch to another tab for some time and come back, the seek bar hasn't progressed while the dialog wasn't shown. So the time shown would be incorrect until another route status update is received.
,
Sep 7 2017
I'd like to request a merge of the above CL to M62.
,
Sep 8 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65e57c2788a72f13e1855a3074f5ab6416aad8fb commit 65e57c2788a72f13e1855a3074f5ab6416aad8fb Author: Takumi Fujimoto <takumif@chromium.org> Date: Fri Sep 08 18:42:01 2017 [Media Router WebUI] Increment seek bar position based on time passed Instead of incrementing the time by 1 second each time the timeout callback is called, we update the time based on how much time has passed since the last route status update. This fixes the bug in which the time doesn't get incremented when we're on another tab. TBR=takumif@chromium.org (cherry picked from commit 8736bdf82af074f246c448c9483d3fd2cb33131f) Bug: 761527 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I42a0a0ff4feaadafdfa04662a173829949ac6ca5 Reviewed-on: https://chromium-review.googlesource.com/647408 Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500326} Reviewed-on: https://chromium-review.googlesource.com/657461 Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#91} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/65e57c2788a72f13e1855a3074f5ab6416aad8fb/chrome/browser/resources/media_router/elements/route_controls/route_controls.js [modify] https://crrev.com/65e57c2788a72f13e1855a3074f5ab6416aad8fb/chrome/test/data/webui/media_router/route_controls_tests.js
,
Sep 12 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 7 2017