Replace 'python' string in python tools to sys.executable |
|
Issue description'python' may start a batch file, which has annoying side effects. Reusing sys.executable from a python script assures that the exact same python runtime is used for the subprocess.
,
Sep 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec92099a42a19f4193ecc70d036b8aa3fbb9fe9b commit ec92099a42a19f4193ecc70d036b8aa3fbb9fe9b Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Mon Sep 04 13:52:26 2017 Switch all 'python' strings to input_api.python_executable in PRESUBMIT.py This guarantees that the same python runtime is used throughput the presubmit checks. This also saves an unnecessary cmd.exe process on Windows, which saves a few ms. TBR=vadimsh@chromium.org BUG=761523 Change-Id: I32ef6966fbd33835ec9d4d9d4a9628d759c86884 Reviewed-on: https://chromium-review.googlesource.com/648446 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#499496} [modify] https://crrev.com/ec92099a42a19f4193ecc70d036b8aa3fbb9fe9b/tools/checkteamtags/PRESUBMIT.py [modify] https://crrev.com/ec92099a42a19f4193ecc70d036b8aa3fbb9fe9b/tools/metrics/actions/PRESUBMIT.py [modify] https://crrev.com/ec92099a42a19f4193ecc70d036b8aa3fbb9fe9b/tools/metrics/histograms/PRESUBMIT.py [modify] https://crrev.com/ec92099a42a19f4193ecc70d036b8aa3fbb9fe9b/tools/metrics/rappor/PRESUBMIT.py [modify] https://crrev.com/ec92099a42a19f4193ecc70d036b8aa3fbb9fe9b/tools/metrics/ukm/PRESUBMIT.py
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1433983fc3fba8b536ea61a740d3700a66d7f1b commit c1433983fc3fba8b536ea61a740d3700a66d7f1b Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Tue Jun 12 18:44:26 2018 Switch 'python' string to sys.executable in python scripts. This guarantees that the same python runtime is used as the calling script. This also saves an unnecessary cmd.exe process on Windows, which saves a few ms. Add notes about commands that are run remotely. TBR=mmeade@chromium.org BUG=761523 Change-Id: I84e809be158f747425ac486d40a92f29e1278d1c Reviewed-on: https://chromium-review.googlesource.com/648351 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#566517} [modify] https://crrev.com/c1433983fc3fba8b536ea61a740d3700a66d7f1b/testing/chromoting/multi_machine_example/example_test_controller.py [modify] https://crrev.com/c1433983fc3fba8b536ea61a740d3700a66d7f1b/testing/legion/examples/comm_server/controller.py [modify] https://crrev.com/c1433983fc3fba8b536ea61a740d3700a66d7f1b/testing/legion/lib/task_controller.py |
|
►
Sign in to add a comment |
|
Comment 1 by mar...@chromium.org
, Sep 1 2017