New issue
Advanced search Search tips

Issue 761520 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-XR



Sign in to add a comment

Re-enable WebVR autopresent instrumentation test

Project Member Reported by bsheedy@chromium.org, Sep 1 2017

Issue description

The one WebVR autopresent test we have was disabled since it stopped working with the switch to using CCT. It should be possible to get the test working again in CTA by mocking out the function that checks whether a given intent is a CCT intent (currently returns true if the intent is a Daydream intent) so that it opens in CTA again instead of CCT.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e1308a247f85a57365e17f9eed26ea6cea8db04

commit 5e1308a247f85a57365e17f9eed26ea6cea8db04
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Sep 13 18:19:59 2017

Re-enabled WebVR autopresent test

Re-enables the WebVR autopresent test that was disabled due to being
incompatible with the change to use CCTs for autopresenting intents.

The test has been rewritten to grab the opened CCT instead of forcing
the intent to open in CTA like initially suggested.

Bug:  761520 
Change-Id: Ie2342698941abc1e9d9cf0c6b70e33050827362f
Reviewed-on: https://chromium-review.googlesource.com/662924
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501697}
[modify] https://crrev.com/5e1308a247f85a57365e17f9eed26ea6cea8db04/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java

Status: Fixed (was: Started)
Components: Internals>XR

Sign in to add a comment