New issue
Advanced search Search tips

Issue 761518 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc optin flex height layout

Project Member Reported by lgcheng@google.com, Sep 1 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83767fefa1bbf7bcb1d2f4edd56a1901adb19bd7

commit 83767fefa1bbf7bcb1d2f4edd56a1901adb19bd7
Author: lgcheng <lgcheng@google.com>
Date: Fri Sep 01 23:58:24 2017

arc optin height adjustment.

After we add change error string more readable in
https://bugs.chromium.org/p/chromium/issues/detail?id=754743
subtitle can be multiple lines and break height calculation. 
Move title and subtitle into content and make content flex
display.

Remove empty spacing of error image so that UI is more robust
if we have multiple line subtitle in different languages.

Bug:  761518 
Test: Manual. No UI accessibility regression.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifc757f337fe93b1a55c1796c8ceb847d73e56d24
Reviewed-on: https://chromium-review.googlesource.com/648333
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#499346}
[modify] https://crrev.com/83767fefa1bbf7bcb1d2f4edd56a1901adb19bd7/chrome/browser/resources/chromeos/arc_support/images/error_image.png
[modify] https://crrev.com/83767fefa1bbf7bcb1d2f4edd56a1901adb19bd7/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/83767fefa1bbf7bcb1d2f4edd56a1901adb19bd7/chrome/browser/resources/chromeos/arc_support/main.html

Comment 2 by lgcheng@google.com, Sep 5 2017

Labels: Merge-Request-62

Comment 3 by lgcheng@google.com, Sep 5 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 6 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e9eebc427bf4c8269404e388240bb1a2b13438e

commit 3e9eebc427bf4c8269404e388240bb1a2b13438e
Author: lgcheng <lgcheng@google.com>
Date: Wed Sep 06 17:33:54 2017

arc optin height adjustment.

After we add change error string more readable in
https://bugs.chromium.org/p/chromium/issues/detail?id=754743
subtitle can be multiple lines and break height calculation. 
Move title and subtitle into content and make content flex
display.

Remove empty spacing of error image so that UI is more robust
if we have multiple line subtitle in different languages.

TBR=xiyuan@chromium.org

Bug:  761518 
Test: Manual. No UI accessibility regression.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifc757f337fe93b1a55c1796c8ceb847d73e56d24
Reviewed-on: https://chromium-review.googlesource.com/648333
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#499346}(cherry picked from commit 83767fefa1bbf7bcb1d2f4edd56a1901adb19bd7)
Reviewed-on: https://chromium-review.googlesource.com/653577
Reviewed-by: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/branch-heads/3202@{#48}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/3e9eebc427bf4c8269404e388240bb1a2b13438e/chrome/browser/resources/chromeos/arc_support/images/error_image.png
[modify] https://crrev.com/3e9eebc427bf4c8269404e388240bb1a2b13438e/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/3e9eebc427bf4c8269404e388240bb1a2b13438e/chrome/browser/resources/chromeos/arc_support/main.html

Comment 6 by lgcheng@google.com, Sep 8 2017

Cc: mkarkada@chromium.org dhadd...@chromium.org sdantul...@chromium.org abod...@chromium.org lgcheng@google.com
 Issue 763576  has been merged into this issue.
Status: Verified (was: Fixed)
Verified on M-62 dev (Chrome OS 9901.29.0/ 62.0.3202.31)

Sign in to add a comment