New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761514 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

AssertionError when running a Pinpoint build

Project Member Reported by dtu@chromium.org, Sep 1 2017

Issue description

Background:
Pinpoint is the new performance bisection service. It has the ability to run perf bisections and perf tryjobs.

During the course of a job, it may encounter a revision that has not been built previously by the perf waterfall. Usually, these are DEPS rolls (e.g. chromium@a + v8@b) or revisions with a patch applied. So Pinpoint has a set of builders on tryserver.chromium.perf that are set up to mimic the perf waterfall builders by using the chromium_trybot recipe.

Error:
When running a build that does have a patch, the build runs green and produces all the correct artifacts.
https://build.chromium.org/p/tryserver.chromium.perf/builders/Mac%20Builder/builds/94

When running a build without a patch, it produces an AssertionError.
https://build.chromium.org/p/tryserver.chromium.perf/builders/Mac%20Builder/builds/99

Here's a CL to change the AssertionError. Let me know if I should do something else instead.
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/645835

Traceback (most recent call last):
  File "/b/rr/tmp15cVp6/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/run.py", line 328, in _new_run
    recipe_result = recipe_script.run(api, properties)
  File "/b/rr/tmp15cVp6/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 98, in run
    self.run_steps, properties, self.PROPERTIES, api=api)
  File "/b/rr/tmp15cVp6/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 627, in invoke_with_properties
    **additional_args)
  File "/b/rr/tmp15cVp6/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 588, in _invoke_with_properties
    return callable_obj(*props, **additional_args)
  File "/b/rr/tmp15cVp6/rw/checkout/scripts/slave/recipes/chromium_trybot.py", line 45, in RunSteps
    return api.chromium_tests.trybot_steps()
  File "/b/rr/tmp15cVp6/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 745, in _inner
    return func(*a, **kw)
  File "/b/rr/tmp15cVp6/rw/checkout/scripts/slave/recipe_modules/chromium_tests/api.py", line 885, in trybot_steps
    disable_deapply_patch) = self._trybot_steps_internal()
  File "/b/rr/tmp15cVp6/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 745, in _inner
    return func(*a, **kw)
  File "/b/rr/tmp15cVp6/rw/checkout/scripts/slave/recipe_modules/chromium_tests/api.py", line 930, in _trybot_steps_internal
    self.m.tryserver.set_subproject_tag(subproject_tag)
  File "/b/rr/tmp15cVp6/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 745, in _inner
    return func(*a, **kw)
  File "/b/rr/tmp15cVp6/rw/checkout/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/tryserver/api.py", line 109, in set_subproject_tag
    assert self.is_tryserver
AssertionError
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d36166bff466d8190d7943a93f97253d0616f995

commit d36166bff466d8190d7943a93f97253d0616f995
Author: Dave Tu <dtu@chromium.org>
Date: Tue Sep 05 16:38:36 2017

chromium_tests: Only set subproject tag if is tryserver.

Bug:  761514 
Change-Id: I6c5179ac913d83f91f59aad7c4aba303349f1a71
Reviewed-on: https://chromium-review.googlesource.com/650213
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: David Tu <dtu@chromium.org>

[modify] https://crrev.com/d36166bff466d8190d7943a93f97253d0616f995/scripts/slave/recipe_modules/chromium_tests/api.py

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ece5e10a86bd22240957ab7880e8b4ab90cb3c32

commit ece5e10a86bd22240957ab7880e8b4ab90cb3c32
Author: Dave Tu <dtu@chromium.org>
Date: Thu Sep 07 19:55:27 2017

chromium_tests: Only run analyze if there's a patch.

For the Pinpoint builders, all the compile targets are being excluded because does_patch_require_compile() returns false. In this case, there's no patch.

Bug:  761514 
Change-Id: Ie5cabd56d21fd0740bd7a98395233fd833dc581b
Reviewed-on: https://chromium-review.googlesource.com/651277
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: David Tu <dtu@chromium.org>

[modify] https://crrev.com/ece5e10a86bd22240957ab7880e8b4ab90cb3c32/scripts/slave/recipe_modules/chromium_tests/api.py

Comment 3 by dtu@chromium.org, Sep 7 2017

Status: Verified (was: Assigned)

Sign in to add a comment