New issue
Advanced search Search tips

Issue 761501 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

TalkBack reads "end of field" inside combo boxes on the web

Project Member Reported by dmazz...@chromium.org, Sep 1 2017

Issue description

From b/63670057

This is related to b/38251811, however, this time the issue is with combo boxes, particularly, with Google Search.

STEPS TO REPRODUCE:
1. Launch TalkBack, Settings -> Accessibility -> TalkBack.
2. Open google.com in Chrome browser, then focus on a "search" field.
3. Begin typing the search term and observe.

EXPECTED RESULTS:
TalkBack should announce what is being typed.

OBSERVED RESULTS:
TalkBack speaks "end of field" for each character typed.

ADDITIONAL INFORMATION:

TalkBack version: 6.1
Android version: O and possibly others

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a1987ec20dbb890a2e57ae33cb5013e5235e468

commit 7a1987ec20dbb890a2e57ae33cb5013e5235e468
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Sep 06 01:10:34 2017

Combo boxes might be editable (Android accessibility)

A more comprehensive fix is coming here:
https://chromium-review.googlesource.com/c/chromium/src/+/642056

This is just a smaller patch in the meantime that fixes the
critical usability issue on Android - when a text field has a
role of combo box we're not treating it as editable text so
TalkBack doesn't support cursoring through it.

This affects the google.com search box.

Bug:  761501 
Change-Id: I7473f7a61e0b082b3c26ad86361a5e1463aad5e8
Reviewed-on: https://chromium-review.googlesource.com/647339
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499829}
[modify] https://crrev.com/7a1987ec20dbb890a2e57ae33cb5013e5235e468/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/7a1987ec20dbb890a2e57ae33cb5013e5235e468/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/7a1987ec20dbb890a2e57ae33cb5013e5235e468/content/test/data/accessibility/aria/aria-autocomplete-expected-android.txt
[modify] https://crrev.com/7a1987ec20dbb890a2e57ae33cb5013e5235e468/content/test/data/accessibility/aria/aria-haspopup-expected-android.txt
[modify] https://crrev.com/7a1987ec20dbb890a2e57ae33cb5013e5235e468/content/test/data/accessibility/aria/aria-orientation-expected-android.txt
[modify] https://crrev.com/7a1987ec20dbb890a2e57ae33cb5013e5235e468/content/test/data/accessibility/aria/aria-readonly-expected-android.txt
[modify] https://crrev.com/7a1987ec20dbb890a2e57ae33cb5013e5235e468/content/test/data/accessibility/aria/aria-searchbox-expected-android.txt
[modify] https://crrev.com/7a1987ec20dbb890a2e57ae33cb5013e5235e468/content/test/data/accessibility/aria/aria-searchbox-with-selection-expected-android.txt
[modify] https://crrev.com/7a1987ec20dbb890a2e57ae33cb5013e5235e468/content/test/data/accessibility/html/input-suggestions-source-element-expected-android.txt

Labels: Merge-Request-62
Not a new regression, but requesting a merge to M62 since it impacts google.com and the Android accessibility team has requested we get this fix in as soon as possible.

I deliberately did a small, safe fix here that's easy to merge, and I'm following up with a larger refactoring to address the underlying issue on trunk.

Project Member

Comment 3 by sheriffbot@chromium.org, Sep 8 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 12 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 15 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 20 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a343c8cd0246dfceb815ec48978f1836d56a6a13

commit a343c8cd0246dfceb815ec48978f1836d56a6a13
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Sep 20 05:35:07 2017

Merge to M62: Combo boxes might be editable (Android accessibility)

A more comprehensive fix is coming here:
https://chromium-review.googlesource.com/c/chromium/src/+/642056

This is just a smaller patch in the meantime that fixes the
critical usability issue on Android - when a text field has a
role of combo box we're not treating it as editable text so
TalkBack doesn't support cursoring through it.

This affects the google.com search box.

Bug:  761501 
Change-Id: I7473f7a61e0b082b3c26ad86361a5e1463aad5e8
Reviewed-on: https://chromium-review.googlesource.com/647339
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499829}(cherry picked from commit 7a1987ec20dbb890a2e57ae33cb5013e5235e468)
Reviewed-on: https://chromium-review.googlesource.com/674532
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#348}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/a343c8cd0246dfceb815ec48978f1836d56a6a13/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/a343c8cd0246dfceb815ec48978f1836d56a6a13/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/a343c8cd0246dfceb815ec48978f1836d56a6a13/content/test/data/accessibility/aria/aria-autocomplete-expected-android.txt
[modify] https://crrev.com/a343c8cd0246dfceb815ec48978f1836d56a6a13/content/test/data/accessibility/aria/aria-haspopup-expected-android.txt
[modify] https://crrev.com/a343c8cd0246dfceb815ec48978f1836d56a6a13/content/test/data/accessibility/aria/aria-orientation-expected-android.txt
[modify] https://crrev.com/a343c8cd0246dfceb815ec48978f1836d56a6a13/content/test/data/accessibility/aria/aria-readonly-expected-android.txt
[modify] https://crrev.com/a343c8cd0246dfceb815ec48978f1836d56a6a13/content/test/data/accessibility/aria/aria-searchbox-expected-android.txt
[modify] https://crrev.com/a343c8cd0246dfceb815ec48978f1836d56a6a13/content/test/data/accessibility/aria/aria-searchbox-with-selection-expected-android.txt
[modify] https://crrev.com/a343c8cd0246dfceb815ec48978f1836d56a6a13/content/test/data/accessibility/html/input-suggestions-source-element-expected-android.txt

On latest M62: 62.0.3202.38 , it announces the typed character only, its doesn't speak "end of field". Thanks  
Status: Fixed (was: Assigned)

Sign in to add a comment