New issue
Advanced search Search tips

Issue 761499 link

Starred by 1 user
Status: Fixed
Owner:
dmazz...@chromium.org
Closed: Sep 2017
Cc:
elawrence@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

ui/accessibility/ax_event_generator.h doesn't compile on win clang dbg

Project Member Reported by dmazz...@chromium.org, Sep 1 2017 
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang(dbg)

https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29/builds/17132

C:\b\c\goma_client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes  @obj/ui/accessibility/accessibility/ax_event_generator.obj.rsp /c ../../ui/accessibility/ax_event_generator.cc /Foobj/ui/accessibility/accessibility/ax_event_generator.obj /Fd"obj/ui/accessibility/accessibility_cc.pdb"
In file included from ../../ui/accessibility/ax_event_generator.cc:5:
../..\ui/accessibility/ax_event_generator.h(55,3):  error: [chromium-style] Complex class/struct needs an explicit out-of-line destructor.
  class AX_EXPORT Iterator
  ^
1 error generated.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a62aea7a676b02ef09717aabd7b4213420893fc

commit 8a62aea7a676b02ef09717aabd7b4213420893fc
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Fri Sep 01 22:03:03 2017

Fix win clang build

TBR=elawrence@chromium.org

Bug:  761499 
Change-Id: Ifc015e77b3ef884a3c9e977ea8622aa4e73bfdf4
Reviewed-on: https://chromium-review.googlesource.com/647778
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499323}
[modify] https://crrev.com/8a62aea7a676b02ef09717aabd7b4213420893fc/ui/accessibility/ax_event_generator.cc
[modify] https://crrev.com/8a62aea7a676b02ef09717aabd7b4213420893fc/ui/accessibility/ax_event_generator.h

Comment 2 by dmazz...@chromium.org, Sep 5 2017

Status: Fixed (was: Started)
►

Sign in to add a comment