Currently, cross-origin same-process iframes that are positioned outside the viewport bounds of the screen have their rendering throttled to save resources. However, this is not true when an iframe is out-of-process from its parent. See: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/LocalFrameView.cpp?l=357&rcl=3c98b1db64a560b684b06dc8ea3b2434eb745774 Since OOPIFs now function properly with IntersectionObserver ( bug 615156 ) and requestAnimationFrame ( bug 529785 ), there shouldn't be any remaining blockers to making them throttle properly. One thing that might need investigation is a comment by esprehn@ about being unable to throttle the main frame because "the root compositor doesn't get setup properly." It's not clear if that would cause a problem here, since we would be throttling the main frame for an OOPIF's compositor. (see: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/LocalFrameView.cpp?l=266&rcl=3c98b1db64a560b684b06dc8ea3b2434eb745774)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d commit 5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d Author: Ken Buchanan <kenrb@chromium.org> Date: Mon Nov 13 02:03:24 2017 Enable render throttling for OOPIFs Throttle OOPIFs when they are off screen or clipped. This adds a VisibilityObserver to RemoteFrames with LocalFrame parents, and sends an update across processes to the OOPIF when throttling status should change. This also fixes ScreenOrientation browser tests which has some flakiness in OOPIF tests that appears when this patch is applied. Bug: 761478 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I9bfb57058e534e796c23e238664a66a142be3c4a Reviewed-on: https://chromium-review.googlesource.com/719601 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#515875} [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/content/browser/frame_host/cross_process_frame_connector.cc [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/content/browser/frame_host/cross_process_frame_connector.h [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/content/browser/renderer_host/frame_connector_delegate.cc [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/content/browser/renderer_host/frame_connector_delegate.h [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/content/browser/renderer_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/content/common/frame_messages.h [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/content/common/view_messages.h [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/content/renderer/render_frame_proxy.cc [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/content/renderer/render_frame_proxy.h [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/content/renderer/render_widget.cc [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/content/renderer/render_widget.h [add] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/LayoutTests/http/tests/dom/raf-throttling-out-of-view-cross-origin-page.html [add] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/LayoutTests/http/tests/dom/resources/raf-throttling-frame.html [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/Source/core/frame/LocalFrameView.h [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/Source/core/frame/RemoteFrameClient.h [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/Source/core/frame/RemoteFrameView.h [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/Source/core/loader/EmptyClients.h [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/public/web/WebFrameWidget.h [modify] https://crrev.com/5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d/third_party/WebKit/public/web/WebRemoteFrameClient.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/584f5ac236cf8bda787fd44c7a7616fee405b66f commit 584f5ac236cf8bda787fd44c7a7616fee405b66f Author: Colin Blundell <blundell@chromium.org> Date: Mon Nov 13 11:16:45 2017 Revert "Enable render throttling for OOPIFs" This reverts commit 5abd7bfc86929cf97858d1e0a7e2d4d73fda0e2d. Reason for revert: Suspected of causing PointerLockBrowserTest flake as detailed on crbug.com/784236 . Original change's description: > Enable render throttling for OOPIFs > > Throttle OOPIFs when they are off screen or clipped. This adds a > VisibilityObserver to RemoteFrames with LocalFrame parents, and > sends an update across processes to the OOPIF when throttling status > should change. > > This also fixes ScreenOrientation browser tests which has some > flakiness in OOPIF tests that appears when this patch is applied. > > Bug: 761478 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: I9bfb57058e534e796c23e238664a66a142be3c4a > Reviewed-on: https://chromium-review.googlesource.com/719601 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Stefan Zager <szager@chromium.org> > Commit-Queue: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515875} TBR=dcheng@chromium.org,kenrb@chromium.org,szager@chromium.org,alexmos@chromium.org Change-Id: If713f93ff75ef4ea45853052fa05c3095f13e8aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 761478 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/765847 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#515923} [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/content/browser/frame_host/cross_process_frame_connector.cc [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/content/browser/frame_host/cross_process_frame_connector.h [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/content/browser/renderer_host/frame_connector_delegate.cc [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/content/browser/renderer_host/frame_connector_delegate.h [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/content/browser/renderer_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/content/common/frame_messages.h [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/content/common/view_messages.h [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/content/renderer/render_frame_proxy.cc [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/content/renderer/render_frame_proxy.h [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/content/renderer/render_widget.cc [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/content/renderer/render_widget.h [delete] https://crrev.com/500392eb0289b96d17134ade9e3281e4a40d7878/third_party/WebKit/LayoutTests/http/tests/dom/raf-throttling-out-of-view-cross-origin-page.html [delete] https://crrev.com/500392eb0289b96d17134ade9e3281e4a40d7878/third_party/WebKit/LayoutTests/http/tests/dom/resources/raf-throttling-frame.html [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/third_party/WebKit/Source/core/frame/LocalFrameView.h [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/third_party/WebKit/Source/core/frame/RemoteFrameClient.h [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/third_party/WebKit/Source/core/frame/RemoteFrameView.h [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/third_party/WebKit/Source/core/loader/EmptyClients.h [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/third_party/WebKit/public/web/WebFrameWidget.h [modify] https://crrev.com/584f5ac236cf8bda787fd44c7a7616fee405b66f/third_party/WebKit/public/web/WebRemoteFrameClient.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/967badcc77752201fa0e6c68524af2d9434efd1f commit 967badcc77752201fa0e6c68524af2d9434efd1f Author: Ken Buchanan <kenrb@chromium.org> Date: Tue Nov 14 22:15:57 2017 Reland: Enable render throttling for OOPIFs Originally landed here: https://chromium-review.googlesource.com/c/chromium/src/+/719601 The change caused a racy test to flake on Mac and was reverted. This patch restores the original CL and fixes the cause of the flakiness in the problematic test. TBR=dcheng@chromium.org Bug: 761478 , 784236 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I0a4da143505b60ce21083413f741e4fe24b0db42 Reviewed-on: https://chromium-review.googlesource.com/769489 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#516454} [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/frame_host/cross_process_frame_connector.cc [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/frame_host/cross_process_frame_connector.h [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/pointer_lock_browsertest.cc [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/renderer_host/frame_connector_delegate.cc [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/renderer_host/frame_connector_delegate.h [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/renderer_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/common/frame_messages.h [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/common/view_messages.h [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/renderer/render_frame_proxy.cc [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/renderer/render_frame_proxy.h [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/renderer/render_widget.cc [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/renderer/render_widget.h [add] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/LayoutTests/http/tests/dom/raf-throttling-out-of-view-cross-origin-page.html [add] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/LayoutTests/http/tests/dom/resources/raf-throttling-frame.html [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/LocalFrameView.h [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/RemoteFrameClient.h [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/RemoteFrameView.h [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/loader/EmptyClients.h [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/public/web/WebFrameWidget.h [modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/public/web/WebRemoteFrameClient.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814 commit e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814 Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Nov 15 00:33:03 2017 Revert "Reland: Enable render throttling for OOPIFs" This reverts commit 967badcc77752201fa0e6c68524af2d9434efd1f. Reason for revert: looks like content_browsertests failing on chromium.mac/Mac10.10 Tests in PointerLockBrowserTest.PointerLockEventRouting and this might be the culprit Original change's description: > Reland: Enable render throttling for OOPIFs > > Originally landed here: > https://chromium-review.googlesource.com/c/chromium/src/+/719601 > > The change caused a racy test to flake on Mac and was reverted. This > patch restores the original CL and fixes the cause of the flakiness in > the problematic test. > > TBR=dcheng@chromium.org > > Bug: 761478 , 784236 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: I0a4da143505b60ce21083413f741e4fe24b0db42 > Reviewed-on: https://chromium-review.googlesource.com/769489 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516454} TBR=kenrb@chromium.org,alexmos@chromium.org Change-Id: I6d35267d8b5eb361ccc56bd62148edc6acb7dd14 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 761478 , 784236 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/770270 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#516520} [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/frame_host/cross_process_frame_connector.cc [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/frame_host/cross_process_frame_connector.h [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/pointer_lock_browsertest.cc [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/renderer_host/frame_connector_delegate.cc [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/renderer_host/frame_connector_delegate.h [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/renderer_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/common/frame_messages.h [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/common/view_messages.h [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/renderer/render_frame_proxy.cc [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/renderer/render_frame_proxy.h [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/renderer/render_widget.cc [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/renderer/render_widget.h [delete] https://crrev.com/576ff94f80108eaf2c8fed6780a629f36e49b4a5/third_party/WebKit/LayoutTests/http/tests/dom/raf-throttling-out-of-view-cross-origin-page.html [delete] https://crrev.com/576ff94f80108eaf2c8fed6780a629f36e49b4a5/third_party/WebKit/LayoutTests/http/tests/dom/resources/raf-throttling-frame.html [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/LocalFrameView.h [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/RemoteFrameClient.h [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/RemoteFrameView.h [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/loader/EmptyClients.h [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/public/web/WebFrameWidget.h [modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/public/web/WebRemoteFrameClient.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9 commit 8a319fbc7039bf38fe46bf7c5f78cca4e82206b9 Author: Ken Buchanan <kenrb@chromium.org> Date: Wed Nov 15 18:37:12 2017 Reland: Enable render throttling for OOPIFs Originally landed here: https://chromium-review.googlesource.com/c/chromium/src/+/719601 The change caused a racy test to flake on Mac and was reverted. This patch restores the original CL and fixes the cause of the flakiness in the problematic test. Was earlier relanded with a fix to only one of the two tests that had race conditions. TBR=dcheng@chromium.org Bug: 761478 , 784236 , 785080 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I947a70b256b0783b2c687c1213c6e00fe06550a8 Reviewed-on: https://chromium-review.googlesource.com/771773 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#516758} [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/frame_host/cross_process_frame_connector.cc [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/frame_host/cross_process_frame_connector.h [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/pointer_lock_browsertest.cc [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/renderer_host/frame_connector_delegate.cc [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/renderer_host/frame_connector_delegate.h [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/renderer_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/common/frame_messages.h [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/common/view_messages.h [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/renderer/render_frame_proxy.cc [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/renderer/render_frame_proxy.h [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/renderer/render_widget.cc [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/renderer/render_widget.h [add] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/LayoutTests/http/tests/dom/raf-throttling-out-of-view-cross-origin-page.html [add] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/LayoutTests/http/tests/dom/resources/raf-throttling-frame.html [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/LocalFrameView.h [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameClient.h [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameView.h [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/loader/EmptyClients.h [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/public/web/WebFrameWidget.h [modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/public/web/WebRemoteFrameClient.h
Comment 1 by creis@chromium.org
, Oct 31 2017